Ensure misdefined active flags will not prevent user syncing #8525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snipe
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an IT person were to inadvertently mis-define their
ldap_active_flagflag in Snipe-IT, no LDAP users would've been able to log in. TheisLdapSync()method would either returnfalse, or raise an Exception.Unfortunately, this is a very common misconfiguration, especially in Active Directory implementations. Previous Snipe-IT versions would loosely permit those misconfigurations and allow LDAP users to log in, regardless. Without fixing this, those misconfigured installations would suddenly stop permitting all LDAP logins.