Implement Liveness probe #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update stale.yml Suggested changes for stale bot to include issues with pull requests * Update stale.yml * Update stale.yml
* Refactor sqs message handling Process all messages received one at a time * Update tests for error handling The existing tests all assumed that errors should be returned from Monitor() if something fails. Now those are logged and no event is generated. Refactor tests to remove go functions and use a channel with non-zero capacity to buffer generated events. * Return error if no messages can be processed If none of the messages received from SQS can be processed, return an error. This will allow the NTH to detect repeated issues processing the queue.
When metric/prometheus endpoint is enabled, we currently have an issue as the PodSecurityPolicy does not allow the pod to bind the ports. This change sorts this issue out (aws#365). Signed-off-by: Maxime VISONNEAU <[email protected]>
Signed-off-by: Victor Boissiere <[email protected]>
Co-authored-by: ec2-bot 🤖 <[email protected]>
* Update README.md * Update README.md
Co-authored-by: Mohammed <[email protected]>
* Provide node labels for webhook template * Move node label to interruptionEvent struct * Fix indent * Update node-termination-handler.go Co-authored-by: Brandon Wagner <[email protected]>
sliaptsou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SUBMIT
Implement Liveness probe (without tests and docs update)
aws#333