Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify queue processor install instructions #366

Merged
merged 1 commit into from
Feb 17, 2021
Merged

clarify queue processor install instructions #366

merged 1 commit into from
Feb 17, 2021

Conversation

brycahta
Copy link
Contributor

Issue #, if available: #346

Description of changes:

  • Moving Helm install instructions above kubectl since it is the most popular installation method and clearest in terms of configuring NTH
  • Added instructions for the minimal config necessary when using kubectl. Noted that the default configs alone will not work because sqs queue will be ""

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brycahta brycahta requested review from bwagner5 and haugenj February 16, 2021 18:50
Copy link
Contributor

@haugenj haugenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@brycahta brycahta merged commit 1050b82 into aws:main Feb 17, 2021
@brycahta brycahta deleted the issue-346 branch February 17, 2021 21:17
haugenj pushed a commit to haugenj/aws-node-termination-handler that referenced this pull request Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants