helm: Add support to override pod monitor namespace #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Boissiere <[email protected]>
Closed
4 tasks
haugenj
pushed a commit
to haugenj/aws-node-termination-handler
that referenced
this pull request
Mar 1, 2021
Signed-off-by: Victor Boissiere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The pod monitor is only created in the Helm release namespace. The Prometheus operator by default watches pod monitors resources only in its own namespace. To watch resources in another namespace, it can be configured to use label selectors. However, in some cases, we do not want to add labels to an already existing namespace like kube-system.
This PR allows overriding the release namespace for the pod monitor. Some other Helm charts already support this feature like the pushgateway.
Testing
Forked the Helm chart and deployed it. Working as intended.
helm template output is working as well: previous release namespace and overridden namespace when the added namespace is uncommented.