Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: added necessary hostPorts in the PodSecurityPolicy #371

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

mvisonneau
Copy link
Contributor

@mvisonneau mvisonneau commented Feb 21, 2021

When metric/prometheus endpoint is enabled, we currently have an issue as the
PodSecurityPolicy does not allow the pod to bind the ports. This change sorts
this issue out (#365).

cc @haugenj

When metric/prometheus endpoint is enabled, we currently have an issue as the
PodSecurityPolicy does not allow the pod to bind the ports. This change sorts
this issue out (aws#365).

Signed-off-by: Maxime VISONNEAU <[email protected]>
Copy link
Contributor

@haugenj haugenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@haugenj haugenj merged commit adcb3f6 into aws:main Feb 23, 2021
@mvisonneau mvisonneau deleted the fix_psp branch February 24, 2021 09:54
haugenj pushed a commit to haugenj/aws-node-termination-handler that referenced this pull request Mar 1, 2021
When metric/prometheus endpoint is enabled, we currently have an issue as the
PodSecurityPolicy does not allow the pod to bind the ports. This change sorts
this issue out (aws#365).

Signed-off-by: Maxime VISONNEAU <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants