Python 88x: merge into main #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
routines for alpha_sp To use the older gsl routines, compile with the switch MATOM_VER=2 The defualit is to use the newer brute force scheme
This incorporates a new version of integration into matom.c. The old version can still be accessed via a compile line switch.
The routine CompareAtomic.py simply looks at two masterfiles and finds differences between the files that are included in the mastefile.
* Improvements to the routines that are used to automatically create templates for rst files input parameters
Only a place holder for a new mode has been added at this point.
Basically, at this point matrix_populations2 is identical to matrix_populations, so this is just a routine to be used to develop a new ionization mode
The normal modes are unchanged but various changes have been made in matrix_ion2 to slow down how rapidly the temperature can change. This still is not fundamentally different from the previous approach.
Previously setting make_tables to yes, just ran windsave totable on each cycle, now the disk_diag file is also saved. Cleaned up writing of the disk_diag file when no photons hit disk.
Variables have been added to the disk structure to allow for better tracking of where photons are emitted from the disk, and where they hit the disk.
Proposed minimal banding change to prevent fewer than 7 ionization bands
xband: windsave2fits, changes to radiation temperature and fixes to disk_diag file.
Fix istat logic for bug #1093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is python 88x, the final version of "python" before it is renamed to Sirocco. The changes are extensive, particularly to documentation and parameter descriptions. In terms of code updates, the main changes I could find through PRs and Issues are:
Code, Data:
Documentation / Admin:
reverb.filter_linedocumentation #1072py_progsusing Sphinx #1076 fixes Add py_progs to sphinx documentation #1075