Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The routine that calculates the fractional convergence is failing #1061

Closed
kslong opened this issue May 7, 2024 · 3 comments
Closed

The routine that calculates the fractional convergence is failing #1061

kslong opened this issue May 7, 2024 · 3 comments

Comments

@kslong
Copy link
Collaborator

kslong commented May 7, 2024

Although the plots associated with convergence appear to suggest that a high degree of convergence is achieved for the standard cv model, the convergence plot created be run_check.py indicates that much lower values of convergence are being achived.

The convergence plots are generated by reading the diagnostic files, but the values there do not appear to agree with what the final convergence plot (as a function of grid cell) is showing

As a guess this has to do with partial and complete celss.

@kslong
Copy link
Collaborator Author

kslong commented May 7, 2024

Note - As an improvement it might be preferable if this kind of info were not stored in the diag file, but in a separate file (or the .sig file) since we do not really want to have to keep the diag files around

@kslong
Copy link
Collaborator Author

kslong commented May 7, 2024

The issue here is that the convergence routine calculates convergence statistics for all plasma cells, and this will include any plasma cells that are only partially in the wind. Since our default now is to ignore cells that are partially in the wind, we get the wrong answer in cases where the number of partial cells is a large fraction of the total.

kslong added a commit that referenced this issue May 7, 2024
The convergence statistics with cycle were incorrect
because all plasma cells including cells were
included.  The fix counts only cells that
are fully in the wind, unless the special mode
to calculate ionizationin partial cells is invoked
@kslong
Copy link
Collaborator Author

kslong commented May 7, 2024

This should not be corrected. It is still the case that the statistics are written to the diagnostic files, and not a special file such as the .sig file, which might be desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant