Fix pack definitions to use define statements and make consistent #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhmatthews
force-pushed
the
fix_pack_definitions
branch
from
bc08d1f to
27429ad
Compare
jhmatthews
added a commit
that referenced
this pull request
Jun 6, 2024
|
This PR was nonsense, it completely broke the code and CI didn't spot it - because we only compile in CI with gcc and so MPI_ON is set to FALSE. Firstly, woops, but also we should try to change the workflow to catch anything broken only in parallel. This was literally a deleted line that means the code can't compile with mpicc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… fluxes and rad forces