[python/ci] Bump up cibuildwheel version, use macos-14, and use MACOSX_DEPLOYMENT_TARGET
#2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
reviewed
May 24, 2024
| @@ -58,7 +58,7 @@ jobs: | |||
| cibw_archs_macos: x86_64 | |||
| wheel-name: macos-x86_64 | |||
| - build: macosx_arm64 | |||
| os: macos-12 | |||
| os: macos-14 | |||
There was a problem hiding this comment.
We should add a note inline that this image is only arm64
johnkerl
changed the title
MACOSX_DEPLOYMENT_TARGET
ryan-williams
added a commit
that referenced
this pull request
May 24, 2024
* restore macos-12 x86 smoke-test see #2634 * `python-packaging.yml`: reduce excess artifact downloads previously each smoke-test job downloaded all {os,arch} wheels * `python-packaging.yml`: allow dispatching against arbitrary ref/branch * `python-packaging.yml`: smoke-tests `fail-fast: false` * improve wheel-build, smoke-test job names * allow download wheels from a previous run * experiment: only build py31* wheels * attempt to parallelize over py-version wheel builds * rm matrix.platform * fix+dash-case per-wheel matrix * smoke-test: {3.10, 3.11} * wheel matrix cleanup * parallel build wheels for all 4 python versions * rm configurable `run-id` * rm inputs.ref * tweak wheel-build / smoke-test GHA job names * [python/ci] Bump up cibuildwheel version, use macos-14, and use `MACOSX_DEPLOYMENT_TARGET` (#2641) * Bump up cibuildwheel version and use macos-14 * Set MACOSX_DEPLOYMENT_TARGET * Enable macos-arm in smoke-tests * Update python-packaging.yml * cr feedback * bump actions/checkout version (fix "node16 actions" warning) --------- Co-authored-by: Dušan Baran <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
May 24, 2024
* restore macos-12 x86 smoke-test see #2634 * `python-packaging.yml`: reduce excess artifact downloads previously each smoke-test job downloaded all {os,arch} wheels * `python-packaging.yml`: allow dispatching against arbitrary ref/branch * `python-packaging.yml`: smoke-tests `fail-fast: false` * improve wheel-build, smoke-test job names * allow download wheels from a previous run * experiment: only build py31* wheels * attempt to parallelize over py-version wheel builds * rm matrix.platform * fix+dash-case per-wheel matrix * smoke-test: {3.10, 3.11} * wheel matrix cleanup * parallel build wheels for all 4 python versions * rm configurable `run-id` * rm inputs.ref * tweak wheel-build / smoke-test GHA job names * [python/ci] Bump up cibuildwheel version, use macos-14, and use `MACOSX_DEPLOYMENT_TARGET` (#2641) * Bump up cibuildwheel version and use macos-14 * Set MACOSX_DEPLOYMENT_TARGET * Enable macos-arm in smoke-tests * Update python-packaging.yml * cr feedback * bump actions/checkout version (fix "node16 actions" warning) --------- Co-authored-by: Dušan Baran <[email protected]>
johnkerl
pushed a commit
that referenced
this pull request
May 24, 2024
* restore macos-12 x86 smoke-test see #2634 * `python-packaging.yml`: reduce excess artifact downloads previously each smoke-test job downloaded all {os,arch} wheels * `python-packaging.yml`: allow dispatching against arbitrary ref/branch * `python-packaging.yml`: smoke-tests `fail-fast: false` * improve wheel-build, smoke-test job names * allow download wheels from a previous run * experiment: only build py31* wheels * attempt to parallelize over py-version wheel builds * rm matrix.platform * fix+dash-case per-wheel matrix * smoke-test: {3.10, 3.11} * wheel matrix cleanup * parallel build wheels for all 4 python versions * rm configurable `run-id` * rm inputs.ref * tweak wheel-build / smoke-test GHA job names * [python/ci] Bump up cibuildwheel version, use macos-14, and use `MACOSX_DEPLOYMENT_TARGET` (#2641) * Bump up cibuildwheel version and use macos-14 * Set MACOSX_DEPLOYMENT_TARGET * Enable macos-arm in smoke-tests * Update python-packaging.yml * cr feedback * bump actions/checkout version (fix "node16 actions" warning) --------- Co-authored-by: Ryan Williams <[email protected]> Co-authored-by: Dušan Baran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.