Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Resolve issues with MacOS wheel-file smoke test #2634

Closed
johnkerl opened this issue May 23, 2024 · 3 comments
Closed

[ci] Resolve issues with MacOS wheel-file smoke test #2634

johnkerl opened this issue May 23, 2024 · 3 comments

Comments

@johnkerl
Copy link
Member

johnkerl commented May 23, 2024 •
edited
Loading

Follow up from #2620 (comment)

[sc-48079]
@johnkerl johnkerl mentioned this issue May 23, 2024
Merged
ryan-williams added a commit that referenced this issue May 24, 2024
@ryan-williams
restore macos-12 x86 smoke-test
1b92ee4 
see #2634
ryan-williams added a commit that referenced this issue May 24, 2024
@ryan-williams
restore macos-12 x86 smoke-test
2bfd85f 
see #2634
@ryan-williams ryan-williams mentioned this issue May 24, 2024
Merged
@ryan-williams
Copy link
Member

Last few relevant changes to the macOS wheel-build and smoke-tests in python-packaging.yml:

X86 ARM
PR macOS wheel build smoke-test macOS wheel build smoke-test
#1385 (May '23) 11 ✅ ✅ 🚫 → 12 🚫 → ✅ 🚫
#2594 (5/20/24) 11 → 12 ✅ ✅ 12 ✅ 🚫
#2491 (5/21/24) 12 → 14 ✅ ❌ 12 ✅ 🚫
#2620 (5/23/24) 14 → 12 ✅ ❌ → 🚫 12 → 14 ✅ 🚫

(✅/❌ = link to representative GHA run, 🚫 = not implemented)

#2594 was the best state to date:

  • macos-12 x {x86,arm} wheels built, x86 smoke-test passed
    • macos-12 EOL is in Q4 (as opposed to macos-11 Q2)
  • No one has gotten macos-14 smoke-tests to work (for x86 or ARM)

#2640 puts us back on macos-12, where at least the x86 smoke-test works. It also adds smoke-tests for Python 3.10 (in addition to 3.11) and parallelizes and cleans up the GHA, for better DX.

Going forward, we can get macos-14 working, or explore an incremental upgrade to macos-13 in the meantime.

ryan-williams added a commit that referenced this issue May 24, 2024
@ryan-williams @dudoslav
Restore/add wheel smoke-tests, parallelize wheel builds (#2640)
d25e60d 
* restore macos-12 x86 smoke-test

see #2634

* `python-packaging.yml`: reduce excess artifact downloads

previously each smoke-test job downloaded all {os,arch} wheels

* `python-packaging.yml`: allow dispatching against arbitrary ref/branch

* `python-packaging.yml`: smoke-tests `fail-fast: false`

* improve wheel-build, smoke-test job names

* allow download wheels from a previous run

* experiment: only build py31* wheels

* attempt to parallelize over py-version wheel builds

* rm matrix.platform

* fix+dash-case per-wheel matrix

* smoke-test: {3.10, 3.11}

* wheel matrix cleanup

* parallel build wheels for all 4 python versions

* rm configurable `run-id`

* rm inputs.ref

* tweak wheel-build / smoke-test GHA job names

* [python/ci] Bump up cibuildwheel version, use macos-14, and use `MACOSX_DEPLOYMENT_TARGET` (#2641)

* Bump up cibuildwheel version and use macos-14

* Set MACOSX_DEPLOYMENT_TARGET

* Enable macos-arm in smoke-tests

* Update python-packaging.yml

* cr feedback

* bump actions/checkout version (fix "node16 actions" warning)

---------

Co-authored-by: Dušan Baran <[email protected]>
github-actions bot pushed a commit that referenced this issue May 24, 2024
@ryan-williams @dudoslav @github-actions
Restore/add wheel smoke-tests, parallelize wheel builds (#2640)
27cbfdc 
* restore macos-12 x86 smoke-test

see #2634

* `python-packaging.yml`: reduce excess artifact downloads

previously each smoke-test job downloaded all {os,arch} wheels

* `python-packaging.yml`: allow dispatching against arbitrary ref/branch

* `python-packaging.yml`: smoke-tests `fail-fast: false`

* improve wheel-build, smoke-test job names

* allow download wheels from a previous run

* experiment: only build py31* wheels

* attempt to parallelize over py-version wheel builds

* rm matrix.platform

* fix+dash-case per-wheel matrix

* smoke-test: {3.10, 3.11}

* wheel matrix cleanup

* parallel build wheels for all 4 python versions

* rm configurable `run-id`

* rm inputs.ref

* tweak wheel-build / smoke-test GHA job names

* [python/ci] Bump up cibuildwheel version, use macos-14, and use `MACOSX_DEPLOYMENT_TARGET` (#2641)

* Bump up cibuildwheel version and use macos-14

* Set MACOSX_DEPLOYMENT_TARGET

* Enable macos-arm in smoke-tests

* Update python-packaging.yml

* cr feedback

* bump actions/checkout version (fix "node16 actions" warning)

---------

Co-authored-by: Dušan Baran <[email protected]>
johnkerl pushed a commit that referenced this issue May 24, 2024
@github-actions @ryan-williams @dudoslav
Restore/add wheel smoke-tests, parallelize wheel builds (#2640) (#2642)
ee00f0a 
* restore macos-12 x86 smoke-test

see #2634

* `python-packaging.yml`: reduce excess artifact downloads

previously each smoke-test job downloaded all {os,arch} wheels

* `python-packaging.yml`: allow dispatching against arbitrary ref/branch

* `python-packaging.yml`: smoke-tests `fail-fast: false`

* improve wheel-build, smoke-test job names

* allow download wheels from a previous run

* experiment: only build py31* wheels

* attempt to parallelize over py-version wheel builds

* rm matrix.platform

* fix+dash-case per-wheel matrix

* smoke-test: {3.10, 3.11}

* wheel matrix cleanup

* parallel build wheels for all 4 python versions

* rm configurable `run-id`

* rm inputs.ref

* tweak wheel-build / smoke-test GHA job names

* [python/ci] Bump up cibuildwheel version, use macos-14, and use `MACOSX_DEPLOYMENT_TARGET` (#2641)

* Bump up cibuildwheel version and use macos-14

* Set MACOSX_DEPLOYMENT_TARGET

* Enable macos-arm in smoke-tests

* Update python-packaging.yml

* cr feedback

* bump actions/checkout version (fix "node16 actions" warning)

---------

Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Dušan Baran <[email protected]>
@johnkerl
Copy link
Member Author

Resolved with #2641 and #2640 -- thanks @ryan-williams and @dudoslav !

@ryan-williams
Copy link
Member

Adding a row to the table above to reflect the current state:

X86 ARM
PR macOS wheel build smoke-test macOS wheel build smoke-test
#1385 (May '23) 11 ✅ ✅ 🚫 → 12 🚫 → ✅ 🚫
#2594 (5/20/24) 11 → 12 ✅ ✅ 12 ✅ 🚫
#2491 (5/21/24) 12 → 14 ✅ ❌ 12 ✅ 🚫
#2620 (5/23/24) 14 → 12 ✅ ❌ → 🚫 12 → 14 ✅ 🚫
#2640/#2641 (5/24/24) 12 ✅ 🚫 → ✅ 14 ✅ 🚫 → ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryan-williams @johnkerl