Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore/add wheel smoke-tests, parallelize wheel builds #2640

Merged
merged 19 commits into from
May 24, 2024

Conversation

ryan-williams
Copy link
Member

@ryan-williams ryan-williams commented May 24, 2024

Issue and/or context: #2634

Changes

Several improvements to python-packaging.yml ("sdist & wheels" GHA):

Before

Screenshot 2024-05-24 at 12 45 28 AM

After

@ryan-williams ryan-williams marked this pull request as ready for review May 24, 2024 04:58
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ryan-williams !

.github/workflows/python-packaging.yml Outdated Show resolved Hide resolved
.github/workflows/python-packaging.yml Outdated Show resolved Hide resolved
.github/workflows/python-packaging.yml Outdated Show resolved Hide resolved
…SX_DEPLOYMENT_TARGET` (#2641)

* Bump up cibuildwheel version and use macos-14

* Set MACOSX_DEPLOYMENT_TARGET

* Enable macos-arm in smoke-tests

* Update python-packaging.yml
@johnkerl
Copy link
Member

johnkerl commented May 24, 2024

Note #2641 has been merged into here

Post-merge manual run: https://github.com/single-cell-data/TileDB-SOMA/actions/runs/9224826375

@ryan-williams ryan-williams force-pushed the rw/macos-12-smoketest branch from 4c1cd23 to 08ca1ab Compare May 24, 2024 14:23
Copy link
Member

@johnkerl johnkerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ryan-williams
Copy link
Member Author

Thanks all, believe I addressed everything, here's a green "wheels" GHA from latest, merging now.

@ryan-williams ryan-williams merged commit d25e60d into main May 24, 2024
24 checks passed
@ryan-williams ryan-williams deleted the rw/macos-12-smoketest branch May 24, 2024 14:47
github-actions bot pushed a commit that referenced this pull request May 24, 2024
* restore macos-12 x86 smoke-test

see #2634

* `python-packaging.yml`: reduce excess artifact downloads

previously each smoke-test job downloaded all {os,arch} wheels

* `python-packaging.yml`: allow dispatching against arbitrary ref/branch

* `python-packaging.yml`: smoke-tests `fail-fast: false`

* improve wheel-build, smoke-test job names

* allow download wheels from a previous run

* experiment: only build py31* wheels

* attempt to parallelize over py-version wheel builds

* rm matrix.platform

* fix+dash-case per-wheel matrix

* smoke-test: {3.10, 3.11}

* wheel matrix cleanup

* parallel build wheels for all 4 python versions

* rm configurable `run-id`

* rm inputs.ref

* tweak wheel-build / smoke-test GHA job names

* [python/ci] Bump up cibuildwheel version, use macos-14, and use `MACOSX_DEPLOYMENT_TARGET` (#2641)

* Bump up cibuildwheel version and use macos-14

* Set MACOSX_DEPLOYMENT_TARGET

* Enable macos-arm in smoke-tests

* Update python-packaging.yml

* cr feedback

* bump actions/checkout version (fix "node16 actions" warning)

---------

Co-authored-by: Dušan Baran <[email protected]>
johnkerl pushed a commit that referenced this pull request May 24, 2024
* restore macos-12 x86 smoke-test

see #2634

* `python-packaging.yml`: reduce excess artifact downloads

previously each smoke-test job downloaded all {os,arch} wheels

* `python-packaging.yml`: allow dispatching against arbitrary ref/branch

* `python-packaging.yml`: smoke-tests `fail-fast: false`

* improve wheel-build, smoke-test job names

* allow download wheels from a previous run

* experiment: only build py31* wheels

* attempt to parallelize over py-version wheel builds

* rm matrix.platform

* fix+dash-case per-wheel matrix

* smoke-test: {3.10, 3.11}

* wheel matrix cleanup

* parallel build wheels for all 4 python versions

* rm configurable `run-id`

* rm inputs.ref

* tweak wheel-build / smoke-test GHA job names

* [python/ci] Bump up cibuildwheel version, use macos-14, and use `MACOSX_DEPLOYMENT_TARGET` (#2641)

* Bump up cibuildwheel version and use macos-14

* Set MACOSX_DEPLOYMENT_TARGET

* Enable macos-arm in smoke-tests

* Update python-packaging.yml

* cr feedback

* bump actions/checkout version (fix "node16 actions" warning)

---------

Co-authored-by: Ryan Williams <[email protected]>
Co-authored-by: Dušan Baran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants