FIX Show correct error message instead of successful message #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
GuySartorelli
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
Tested and more thoroughly reviewed in #1273 - all works well.
|
@sabina-talipova merge on green |
|
The travis build is failing because it is trying to run installer 4.11 - I've created a PR to fix that: #1275 |
…exceeding maximum file size
sabina-talipova
force-pushed
the
pulls/1.10/fix-wrong-message
branch
from
2c12319 to
fb299b3
Compare
GuySartorelli
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
The two remaining travis failures are expected - see comments on #1275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue by adding "complete" event. After the file has been added, wait until the file status will be changed to "successful" or "error", only then update the content and show a message depending on what result will be received from the server.
New test cases were added.
Replaces #1273
Parent issue