Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Show correct error message instead of successful message if file … #1273

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented May 30, 2022

Description

Fixed an issue by adding "complete" event. After the file has been added, wait until the file status will be changed to "successful" or "error", only then update the content and show a message depending on what result will be received from the server.
New test cases were added.

Parent issue

#1248

@sabina-talipova sabina-talipova changed the base branch from 1 to 1.11 May 30, 2022 02:59
@sabina-talipova sabina-talipova force-pushed the pulls/1.11/fix-wrong-message branch from 694e7f3 to d54ae07 Compare May 30, 2022 03:05
@sabina-talipova sabina-talipova force-pushed the pulls/1.11/fix-wrong-message branch 6 times, most recently from 4f31afa to 906539d Compare May 31, 2022 04:09
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well locally, a few things here to tidy up.

tests/behat/src/FixtureContext.php Outdated Show resolved Hide resolved
tests/behat/features/replace-file.feature Outdated Show resolved Hide resolved
tests/behat/src/FixtureContext.php Outdated Show resolved Hide resolved
tests/behat/src/FixtureContext.php Outdated Show resolved Hide resolved
tests/behat/features/replace-file.feature Outdated Show resolved Hide resolved
tests/behat/src/FixtureContext.php Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/1.11/fix-wrong-message branch 8 times, most recently from d60b597 to b4dcd71 Compare June 2, 2022 04:36
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few small indentation changes to make plus some questions for things I don't quite understand.

tests/behat/src/FixtureContext.php Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/1.11/fix-wrong-message branch 2 times, most recently from 57b2abd to a63ed62 Compare June 3, 2022 00:35
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sorry that I only just noticed, but this should be targetting the 1.10 branch (since 1.11 isn't out yet, and this bug fix doesn't include any API changes)

@sabina-talipova sabina-talipova changed the base branch from 1.11 to 1.10 June 9, 2022 02:40
@sabina-talipova sabina-talipova changed the base branch from 1.10 to 1.11 June 9, 2022 02:40
@sabina-talipova sabina-talipova force-pushed the pulls/1.11/fix-wrong-message branch from a63ed62 to 640744c Compare June 9, 2022 02:49
@sabina-talipova
Copy link
Contributor Author

WRONG BRANCH

@sabina-talipova sabina-talipova deleted the pulls/1.11/fix-wrong-message branch June 9, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants