-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Show correct error message instead of successful message if file … #1273
FIX Show correct error message instead of successful message if file … #1273
Conversation
694e7f3
to
d54ae07
Compare
4f31afa
to
906539d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well locally, a few things here to tidy up.
d60b597
to
b4dcd71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few small indentation changes to make plus some questions for things I don't quite understand.
57b2abd
to
a63ed62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sorry that I only just noticed, but this should be targetting the 1.10
branch (since 1.11 isn't out yet, and this bug fix doesn't include any API changes)
a63ed62
to
640744c
Compare
WRONG BRANCH |
Description
Fixed an issue by adding "complete" event. After the file has been added, wait until the file status will be changed to "successful" or "error", only then update the content and show a message depending on what result will be received from the server.
New test cases were added.
Parent issue
#1248