Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message not shown if replacing file with too big file #1248

Closed
2 tasks done
t3hn0 opened this issue Jan 10, 2022 · 1 comment
Closed
2 tasks done

Error message not shown if replacing file with too big file #1248

t3hn0 opened this issue Jan 10, 2022 · 1 comment

Comments

@t3hn0
Copy link

t3hn0 commented Jan 10, 2022

Tested on SS 4.8.0 and on 4.9.0

If I try to upload file that's too big I get error message "Filesize is too large, maximum 25 MB allowed" which is ok.

But if I try to replace existing file with a file (which is too big) Assets Admin shows me success message "Upload successful, the file will be replaced when you Save." although I can see in browsers network tab JSON response was: "{"status":"error","errors":[{"type":"error","code":400,"value":"Filesize is too large, maximum 25 MB allowed"}]}".

Assets Admin shouldn't show success message if upload was not successful. It should display error.

ACs

  • File too large error message shows when attempting to replace a file

PR

@GuySartorelli
Copy link
Member

PR merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants