Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Allow travis to pull the correct installer version #1275

Conversation

GuySartorelli
Copy link
Member

Travis is trying to pull installer 4.11 for tests of PRs on the 1.10 branch.
e.g. https://app.travis-ci.com/github/silverstripe/silverstripe-asset-admin/jobs/572953885

This change allows it to correctly use installer 4.10.x

NOTE this should be merged up immediately after merging, and the change reverted during that merge (so that this change is not reflected in the 1 branch).

@GuySartorelli GuySartorelli force-pushed the pulls/1.10/installer-version-for-tests branch from 672916c to 66b1045 Compare June 9, 2022 03:49
@GuySartorelli GuySartorelli changed the title Pulls/1.10/installer version for tests MNT Allow travis to pull the correct installer version Jun 9, 2022
@GuySartorelli
Copy link
Member Author

Travis failures are PHP8.1 (not supported in framework 1.10) and graphql v4 (the beta has framework 4.11 as a dependency so that just won't ever work for framework/installer 4.10)

@sabina-talipova sabina-talipova self-requested a review June 9, 2022 04:26
@sabina-talipova sabina-talipova merged commit 4e053aa into silverstripe:1.10 Jun 9, 2022
@sabina-talipova sabina-talipova deleted the pulls/1.10/installer-version-for-tests branch June 9, 2022 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants