BUGFIX: Move tab state to redux store instead of reduxForm #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
approved these changes
Oct 17, 2018
7 tasks
raissanorth
pushed a commit
to creative-commoners/silverstripe-admin
that referenced
this pull request
Oct 18, 2018
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Using redux form state causes tabs to be tracked for dirtiness. Changing tabs dirties the form. This causes behat tests to fail as they can't negotiate the
onunloadalert.Solution
Move tab state into plain redux state tree, instead of reduxForm
Resolves
silverstripe/silverstripe-asset-admin#847
Dependencies
silverstripe/silverstripe-framework#8489