Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENHANCEMENT: Extensible readFiles query #847

Merged
merged 9 commits into from
Oct 17, 2018
Merged

ENHANCEMENT: Extensible readFiles query #847

merged 9 commits into from
Oct 17, 2018

Conversation

unclecheese
Copy link

@unclecheese unclecheese commented Oct 11, 2018 •
edited
Loading

Resolves silverstripe/silverstripe-admin#611

NB: Ignore the branch name. Was originally done against 1.2, but have rebased to 1.

@chillu chillu mentioned this pull request Oct 11, 2018
Closed
3 tasks
@unclecheese unclecheese force-pushed the pulls/1.2/sense-and-extensibility branch from 1d01641 to d5104c5 Compare October 11, 2018 02:09
@unclecheese unclecheese changed the base branch from 1.2 to 1 October 11, 2018 02:09
robbieaverill
robbieaverill approved these changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've pushed a commit with a doc block fix in it. I've tested this and everything seems happy in the assets area

@robbieaverill
Copy link
Contributor

Same comment as the admin PR regarding squashing the commits, add a commit prefix and retarget against 1.3

@unclecheese unclecheese changed the base branch from 1 to 1.3 October 15, 2018 20:24
@unclecheese unclecheese force-pushed the pulls/1.2/sense-and-extensibility branch from 8919365 to 247bef7 Compare October 16, 2018 09:37
@unclecheese unclecheese force-pushed the pulls/1.2/sense-and-extensibility branch from 247bef7 to a315950 Compare October 16, 2018 09:43
@unclecheese unclecheese mentioned this pull request Oct 17, 2018
Merged
@unclecheese unclecheese merged commit 902fec0 into silverstripe:1.3 Oct 17, 2018
@unclecheese unclecheese deleted the pulls/1.2/sense-and-extensibility branch October 17, 2018 21:03
@robbieaverill robbieaverill mentioned this pull request Jan 31, 2019
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robbieaverill robbieaverill robbieaverill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unclecheese @robbieaverill