FIX update tab loading to use recent admin module changes #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScopeyNZ
reviewed
Oct 19, 2018
|
Yes, @ScopeyNZ. That's right. Made an additional commit. |
ScopeyNZ
approved these changes
Oct 19, 2018
raissanorth
force-pushed
the
pulls/4.0/heal-tabby-cat
branch
from
6ec751d to
e46b64e
Compare
|
I've published the latest webpack-config, will update this PR |
The admin module previously used the redux-form store to track the active Tab within a Tabs component. However this was recently refactored in the admin module to use a different shard in the redux store, as it was causing problems (functionality regressions) in form state with the asset-admin module. So the logic here in Elemental also required updating.
robbieaverill
force-pushed
the
pulls/4.0/heal-tabby-cat
branch
from
e46b64e to
9fe5f05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR contain a refactor to -reenable setting the tab via the action menu after changes in admin(silverstripe/silverstripe-admin#694).
Fixes #448
Dependent on:
Thanks @NightJar for the awesome peering!