Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Redux tab connection #448

Closed
ScopeyNZ opened this issue Oct 17, 2018 · 3 comments
Closed

Fix Redux tab connection #448

ScopeyNZ opened this issue Oct 17, 2018 · 3 comments
Labels
affects/v4 complexity/medium impact/critical type/bug

Comments

@ScopeyNZ
Copy link
Contributor

A PR has just opened in admin that will break our implementation on tab switching when it is merged:

silverstripe/silverstripe-admin#694

We need to update the dropdown to use these new redux actions (etc).
@raissanorth
Copy link
Contributor

While the PR itself looks good and it shouldn't be too hard to update ElementEditor to use the new Redux actions this brings us back to the original issue. If the state for Tabs is kept in one store than the Tabs for every block will be changed in unison and we are not able to control them individually, are we? Please proof me wrong... 🤞

@ScopeyNZ
Copy link
Contributor Author

The PR on admin has active tabs in the store indexed by the TabSet ID. As long as the IDs are unique...

@robbieaverill robbieaverill mentioned this issue Oct 17, 2018
Merged
@raissanorth raissanorth self-assigned this Oct 18, 2018
This was referenced Oct 18, 2018
Closed
Merged
Merged
Merged
@robbieaverill
Copy link
Contributor

Fixed with the linked PRs above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/medium impact/critical type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ScopeyNZ @robbieaverill @raissanorth