[pull] develop from keepassxreboot:develop #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
`/MP` = Build with multiple processes see https://learn.microsoft.com/en-us/cpp/build/reference/mp-build-with-multiple-processes?view=msvc-170
Each AddAccessAllowedAce invocation should be matched with a corresponding sizeof(ACCESS_ALLOWED_ACE) and the respective GetLengthSid of the SID being used. This ensures that there is enough space in the ACL for each entry. The issue manifest itself only when WITH_XC_SSHAGENT is defined.
* SSH Agent: Fix broken decrypt button (Fixes #10637) --------- Co-authored-by: Jonathan White <[email protected]>
Remove #ifdef guards from Config.h/cpp (no harm to non-Flatpak distros) Cleanup #ifdef usage in NixUtils.cpp
* Fix broken build when using system zxcvbn Fixup of zxcvbn include statement added in 5513ff5. A zxcvbn/ directory prefix breaks building with system zxcvbn. Remove this prefix to align this include statement with ones present in other files. Add zxcvbn libraries as dependency to CliTest. * Move src/zxcvbn/ to src/thirdparty/zxcvbn
* Botan: use raw_private_key_bits() if available Botan 3.x introduces raw_private_key_bits() as an alias for get_private_key(), and deprecates the latter. * Botan: use Cipher_Dir::Encryption Botan 3.x introduces Cipher_Dir::Encryption as an alias for Cipher_Dir::ENCRYPTION, and deprecates the latter. Likewise for Decryption/DECRYPTION.
Remove Unicode character U+FEFF ZERO WIDTH NO-BREAK SPACE from Weslly's email address in a few places. Not sure if this was done on purpose (anti-spam measure?), but it's not consistently done anyway (e.g. wasn't the case in src/gui/TotpDialog.cpp), so it seems cleanest to remove this.
Ensure that files that shouldn't be executable aren't.
Taken from Github topics
* Fix passphrase generator test Previously, the test case was assuming the wrong regex. In particular, the default word list (eff_large.wordlist) contains several words that contain dashes. Adjust the regex used in the test to reflect this. This should fix rare test failures
Fixes #10730. Co-authored-by: Christoph Reiter <[email protected]>
* Fix database view splitters resize behaviour * Set default ratio sizes for first-run based on the size of the database widget itself * Fix setting splitter sizes before database widget has had a chance to render for the first time * Disallow collapsing the entry view (source of several bug reports) Fixes: #10613 --------- Co-authored-by: Jonathan White <[email protected]>
* Provide remote database sync capability Allow arbitrary commands to be defined and executed for syncing databases with remote services. This includes sftp, scp, rsync, etc. Remote commands are stored per-database and sync operations are manually triggered by the user from the Database -> Remote Sync menu. --------- Co-authored-by: Stefan Forstenlechner <[email protected]> Co-authored-by: Jonathan White <[email protected]>
That test failed, presumably because of inherent raciness: https://ci.keepassxc.org/buildConfiguration/KeePassXC_MacOS/248424?expandBuildDeploymentsSection=false&hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildChangesSection=true&expandBuildProblemsSection=true&showLog=248423_1081_942&logFilter=debug&logView=flowAware Paper over the raciness by using QTRY_COMPARE instead of QCOMPARE.
* MainWindow: change Clone Entry shortcut to Ctrl+D from Ctrl+K * MainWindow: move shortcuts from .cpp to .ui file The only shortcuts defined in the .cpp file are ones that can't be defined in the .ui file, because they are in some way conditional. This also reduces the number of compiler warnings of the kind: warning: arithmetic between different enumeration types ‘Qt::Modifier’ and ‘Qt::Key’ is deprecated [-Wdeprecated-enum-enum-conversion] with recent GCC versions.
A warning is issued from Qt when the path is empty. This happens most often during test runs, but can also occur when closing a database before everything gets cleaned up.
* Use SHA256 hash of the file path of the database to generate a UUID when using the KDBX3 format. This restores the original behavior of using the file path as the quick unlock lookup key.
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.17.0 to 0.31.0. - [Commits](golang/crypto@v0.17.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Also includes minor updates to the PR template
* Fixes #11538 - prevent rendering HTML in Title, Password, and URL fields in the entry preview pane.
* Fixes #10213 * Sets copy password/username/totp to Ctrl+Shift+1/2/3 respectively
* An additional approach to create passphrases with one random word being in UPPERCASE. * Also remove duplicate character count from passphrase generator --------- Co-authored-by: Stephan Heffner <[email protected]> Co-authored-by: Jonathan White <[email protected]>
* Clean up removed elements in qt stylesheets * Disable main window when saving * Fixed triangle size in group view --------- Co-authored-by: Jonathan White <[email protected]>
) Fixes #11543 Also fix delayed polling on window activation --------- Co-authored-by: w15dev <[email protected]> Co-authored-by: Jonathan White <[email protected]>
* Closes #10465
* Fixes #4738 * Also fixes flaky handling of caps lock detection events
* Set plain text mode on elements that should never have styling * Revert html escaping as a prior fix
Closes #11506 Closes #3383 * This change adds a new opportunity to add attachments that don’t require a real file in the file system. * Add a new dialog window to add and preview attachments and integrate it into the EntryAttachmentsWidget. * Attachment preview support for images and plain text files. Additional enhancements: * Fix sizing of attachment columns * Add padding to attachment table items * Fix targeting of preview widget styling to not impact unintended children
Closes #1972 Add ability to immediately expire an entry from the context menu --------- Co-authored-by: Jonathan White <[email protected]>
* When running the build outside of a visual studio environment, PCSC libraries may not be discoverable. This change explicitly adds Windows SDK's to the search path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )