Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating attachment from textinput (like copy-paste) #11506

Closed
neufeind opened this issue Nov 28, 2024 · 1 comment · Fixed by #11637
Closed

Allow creating attachment from textinput (like copy-paste) #11506

neufeind opened this issue Nov 28, 2024 · 1 comment · Fixed by #11637
Assignees
Labels
Milestone

Comments

@neufeind
Copy link

neufeind commented Nov 28, 2024

Summary

It would be great to be able to attach certain things (like for example a key) from a text-input and not just by selecting a file. Currently you have to copy-paste into a file first, import that as an attachment and can remove the external file again afterwards.

Examples

Maybe have a button "New" next to "Add" (which currently adds a file)?

Context

I wanted to add ssh-keys from another source, through copy-paste. I had to create files first to be able to attach them to an entry.

@droidmonkey droidmonkey added the ux label Nov 28, 2024
@droidmonkey droidmonkey added this to the v2.8.0 milestone Nov 28, 2024
@droidmonkey droidmonkey self-assigned this Nov 28, 2024
@droidmonkey
Copy link
Member

Good idea

w15eacre pushed a commit to w15eacre/keepassxc that referenced this issue Jan 7, 2025
w15eacre pushed a commit to w15eacre/keepassxc that referenced this issue Jan 7, 2025
w15eacre pushed a commit to w15eacre/keepassxc that referenced this issue Jan 8, 2025
w15eacre pushed a commit to w15eacre/keepassxc that referenced this issue Jan 8, 2025
w15eacre pushed a commit to w15eacre/keepassxc that referenced this issue Jan 8, 2025
w15eacre pushed a commit to w15eacre/keepassxc that referenced this issue Jan 9, 2025
Refactor EntryAttachmentsWidget and PreviewEntryAttachmentsDialog to remove unnecessary parent references

Fixes keepassxreboot#11506
w15eacre pushed a commit to w15eacre/keepassxc that referenced this issue Jan 9, 2025
Refactor EntryAttachmentsWidget and PreviewEntryAttachmentsDialog to remove unnecessary parent references

Fixes keepassxreboot#11506
w15eacre pushed a commit to w15eacre/keepassxc that referenced this issue Jan 9, 2025
droidmonkey pushed a commit that referenced this issue Jan 19, 2025
Closes #11506
Closes #3383

* This change adds a new opportunity to add attachments that don’t require a real file in the file system.
* Add a new dialog window to add and preview attachments and integrate it into the EntryAttachmentsWidget.
* Attachment preview support for images and plain text files.

Additional enhancements:
* Fix sizing of attachment columns
* Add padding to attachment table items
* Fix targeting of preview widget styling to not impact unintended children
pull bot pushed a commit to Graysonbarton/keepassxc that referenced this issue Jan 26, 2025
…eboot#11637)

Closes keepassxreboot#11506
Closes keepassxreboot#3383

* This change adds a new opportunity to add attachments that don’t require a real file in the file system.
* Add a new dialog window to add and preview attachments and integrate it into the EntryAttachmentsWidget.
* Attachment preview support for images and plain text files.

Additional enhancements:
* Fix sizing of attachment columns
* Add padding to attachment table items
* Fix targeting of preview widget styling to not impact unintended children
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants