2.7.8 fails to build on Windows with GCC and Clang

[lazka]

Overview

2.7.7 builds fine, 2.7.8 fails.

GCC fails with:

  In file included from D:/M/msys64/ucrt64/include/QtTest/qtest.h:45,
                   from D:/M/msys64/ucrt64/include/QtTest/QTest:1,
                   from C:/_/B/src/keepassxc-2.7.8/tests/TestDatabase.cpp:23:
  C:/_/B/src/keepassxc-2.7.8/tests/TestDatabase.cpp: In member function 'void TestDatabase::testSaveAs()':
  C:/_/B/src/keepassxc-2.7.8/tests/TestDatabase.cpp:127:34: error: cannot call constructor 'QFileInfo::QFileInfo' directly [-fpermissive]
    127 |     QVERIFY(!QFileInfo::QFileInfo(newDbFileName).isHidden());
        |              ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
  C:/_/B/src/keepassxc-2.7.8/tests/TestDatabase.cpp:127:34: note: for a function-style cast, remove the redundant '::QFileInfo'
  C:/_/B/src/keepassxc-2.7.8/tests/TestDatabase.cpp:130:33: error: cannot call constructor 'QFileInfo::QFileInfo' directly [-fpermissive]
    130 |     QVERIFY(QFileInfo::QFileInfo(newDbFileName).isHidden());
        |             ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
  C:/_/B/src/keepassxc-2.7.8/tests/TestDatabase.cpp:130:33: note: for a function-style cast, remove the redundant '::QFileInfo'

Clang fails with:

   C:/_/B/src/keepassxc-2.7.8/tests/TestDatabase.cpp:127:25: error: qualified reference to 'QFileInfo' is a constructor name rather than a type in this context
    127 |     QVERIFY(!QFileInfo::QFileInfo(newDbFileName).isHidden());
        |                         ^
  C:/_/B/src/keepassxc-2.7.8/tests/TestDatabase.cpp:130:24: error: qualified reference to 'QFileInfo' is a constructor name rather than a type in this context
  
    130 |     QVERIFY(QFileInfo::QFileInfo(newDbFileName).isHidden());
  
        |                        ^

[lazka]

We disabled building the tests downstream now, to work around this.

[droidmonkey]

That's interesting, hadn't failed anywhere with our CI or even GitHub Actions.

[lazka]

This seems to be Windows only code, so maybe just a MSVC vs mingw thing (?)

[droidmonkey]

Good point, I never built tests on mingw, only use it for release of the legacy windows package

[lazka]

I can confirm that this makes it work:

--- keepassxc-2.7.8/tests/TestDatabase.cpp.orig	2024-05-05 22:40:29.000000000 +0200
+++ keepassxc-2.7.8/tests/TestDatabase.cpp	2024-05-11 13:43:53.916506400 +0200
@@ -124,10 +124,10 @@
     QCOMPARE(spyFilePathChanged.count(), 1);
     QVERIFY(QFile::exists(newDbFileName));
 #ifdef Q_OS_WIN
-    QVERIFY(!QFileInfo::QFileInfo(newDbFileName).isHidden());
+    QVERIFY(!QFileInfo(newDbFileName).isHidden());
     SetFileAttributes(newDbFileName.toStdString().c_str(), FILE_ATTRIBUTE_HIDDEN);
     QVERIFY2(db->saveAs(newDbFileName, Database::Atomic, QString(), &error), error.toLatin1());
-    QVERIFY(QFileInfo::QFileInfo(newDbFileName).isHidden());
+    QVERIFY(QFileInfo(newDbFileName).isHidden());
 #endif
     QFile::remove(newDbFileName);
     QVERIFY(!QFile::exists(newDbFileName));