Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being dataset uploader does not make editable true #7200

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Jul 11, 2023

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Create dataset with read acess by non-admin user.
  • Set uploader in db.
  • Ensure that the user still can not edit it (e.g. via PATCH /datasets/org/dataset/updatePartial)

Uploading a dataset requires managing permissions in that folder (see #7199 for an issue arising from that). That way the initial uploading logic should be unaffected.

Issues:

Also "uploader" is not used for remote datasets?


(Please delete unneeded items, merge only when none are left open)

@frcroth frcroth self-assigned this Jul 11, 2023
@frcroth frcroth marked this pull request as ready for review July 11, 2023 12:19
@frcroth frcroth requested a review from fm3 July 11, 2023 12:19
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

No migrations are necessary, I also double-checked that this detail is not mentioned in the docs, so no changes needed there either.

Could you write an additional issue for setting uploader during explore-and-add for remote datasets? I think that would make sense.

Also, good find on the other issue with folder permissions. We should have a look at that soon. (It’s not extremely pressing, though, since most people who add datasets are admin or dataset managers anyway)

@frcroth frcroth merged commit 6972016 into master Jul 18, 2023
@frcroth frcroth deleted the uploader-not-editable branch July 18, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

being dataset uploader should not make isEditable true
2 participants