Being dataset uploader does not make editable true (#7200)

scalableminds · Jul 18, 2023 · 6972016 · 6972016
1 parent 7749e41
commit 6972016
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 2 deletions.
diff --git a/CHANGELOG.unreleased.md b/CHANGELOG.unreleased.md
@@ -26,6 +26,7 @@ For upgrade instructions, please check the [migration guide](MIGRATIONS.released
 - The proofreading tool is always visible now (even when disabled). [#7174](https://github.com/scalableminds/webknossos/pull/7174)
 - Optimized processing of parallel requests (new thread pool configuration, asynchronous FossilDB client), improving performance and reducing idle waiting. [#7139](https://github.com/scalableminds/webknossos/pull/7139)
 - Renamed "open" tasks to "pending" and slightly redesigned the available task assignment view for clarity. [#7187](https://github.com/scalableminds/webknossos/pull/7187)
+- Being the uploader of a dataset no longer grants edit permissions on that dataset. [#7200](https://github.com/scalableminds/webknossos/pull/7200)
 
 ### Fixed
 - Fixed rare rendering bug at viewport edge for anisotropic datasets. [#7163](https://github.com/scalableminds/webknossos/pull/7163)

diff --git a/app/models/binary/DataSet.scala b/app/models/binary/DataSet.scala
@@ -241,7 +241,6 @@ class DataSetDAO @Inject()(sqlClient: SqlClient,
                 (
                   (u.isAdmin AND u._organization = d._organization) OR
                   u.isDatasetManager OR
-                  d._uploader = u._id OR
                   d._id IN (              -- team manager of team that has access to the dataset
                     SELECT _dataSet
                     FROM webknossos.dataSet_allowedTeams dt

diff --git a/app/models/binary/DataSetService.scala b/app/models/binary/DataSetService.scala
@@ -282,7 +282,6 @@ class DataSetService @Inject()(organizationDAO: OrganizationDAO,
         } yield
           (user.isAdminOf(dataSet._organization)
             || user.isDatasetManager
-            || dataSet._uploader.contains(user._id)
             || teamManagerMemberships.map(_.teamId).intersect(dataSetAllowedTeams).nonEmpty)
       case _ => Fox.successful(false)
     }