Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dataset in folder with rights while not having rights to organization root folder #7199

Closed
frcroth opened this issue Jul 11, 2023 · 2 comments · Fixed by #7221
Closed
Assignees

Comments

@frcroth
Copy link
Member

frcroth commented Jul 11, 2023

When a user does not have access rights to the root folder of an organization but access to a different (sub)folder, they can upload a dataset (which is automatically in the root folder) but then not access it (or even complete the import procedure). (additional context: https://scm.slack.com/archives/C5AKLAV0B/p1689069626934229?thread_ts=1689064935.050179&cid=C5AKLAV0B)

Expected Behavior

Two options to fix this:
- Store folder directly on upload so that the dataset is not uploaded into the root directory (preferred)
- Disallow uploading generally when a user does not have access rights to the root directory

Current Behavior

Steps to Reproduce the bug

  1. As the admin user, create a directory and give acess to a non-admin user via team permission (the non-admin user does not have rights to upload in the root directory)
  2. Make the non-admin user team manager
  3. As the non-admin user, try to upload a dataset in that folder
@fm3
Copy link
Member

fm3 commented Jul 13, 2023

I agree that users with this rights configuration should be able to upload into the directories that they have write access for. The information in which folder the dataset should land should be propagated accordingly. I would have expected this to happen already, via /datastores/:name/reserveUpload but apparently there is some bug in that logic.

@philippotto philippotto assigned fm3 and unassigned frcroth Jul 20, 2023
@fm3 fm3 changed the title Uploading dataset in folder with rights while not having rights to organization root folder Adding dataset in folder with rights while not having rights to organization root folder Jul 20, 2023
@fm3
Copy link
Member

fm3 commented Jul 20, 2023

I double-checked that this works for upload, and this issue is concerned with the addRemote aka put datasource variant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants