Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggling tree expands/collapses unrelated subgroups #4162

Closed
valentin-pinkau opened this issue Jul 2, 2019 · 3 comments · Fixed by #4178
Closed

toggling tree expands/collapses unrelated subgroups #4162

valentin-pinkau opened this issue Jul 2, 2019 · 3 comments · Fixed by #4178
Assignees

Comments

@valentin-pinkau
Copy link
Member

The new feature of collapsing subtrees introduced a bug.
Activating subgroups expands or collapses other subgroups.
First bug:
Reproduce: root expand all; click on any tree -> all subgroups collapse
Second bug:
Reproduce: root collapse all; click on any tree -> all subgroups expand

@hotzenklotz
Copy link
Member

hotzenklotz commented Jul 11, 2019

@MichaelBuessemeyer Did you already start with this one? Otherwise I might take a look at it.

@hotzenklotz hotzenklotz self-assigned this Jul 11, 2019
hotzenklotz added a commit that referenced this issue Jul 11, 2019
@MichaelBuessemeyer
Copy link
Contributor

@hotzenklotz I did some follow-up work on the add-collapse-all-groups branch for the pr #4143. But this is not related to the issue/bug.

I also shortly tried to find the bug but did not succeed. If you want you can take a look at it.

@hotzenklotz
Copy link
Member

@MichaelBuessemeyer I have fixed the bug in PR #4178 but nothing more. No usability improvements or other feedback. Just the bug reported here. Feel free to include these other changes as well.

hotzenklotz added a commit that referenced this issue Jul 15, 2019
* fixed expand all trees bug #4162

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants