-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Followup fixes for "collapse/expand all subgroups" #4206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-collapse-all-groups
…bknossos into add-collapse-all-groups
…bknossos into add-collapse-all-groups
MichaelBuessemeyer
changed the title
Add collapse all groups
Followup fixes for "collapse/expand all subgroups"
Jul 26, 2019
daniel-wer
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes look very good to me :) I couldn't find a picture in #4162, but I tested the scenarios and fixes you outlined and they worked very well 👍
Sorry, the correct issue is #4166. I updated the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds small fixes/changes to the behavior of the "collapse/expand all subgroups" feature.
If you expand all subgroups, the group itself is now also automatically expanded.
Previously it was possible to expand all subgroups of a collapsed group, but without expanding the group itself. This needed an extra "expand this group click".
Now the groups deeply check their children whether for expanded/collapsed groups. Previously only the immediate children were checked.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated changelog[ ] Updated migration guide if applicable[ ] Updated documentation if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment