Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup fixes for "collapse/expand all subgroups" #4206

Merged
merged 21 commits into from
Jul 29, 2019

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Jul 26, 2019

This PR adds small fixes/changes to the behavior of the "collapse/expand all subgroups" feature.

If you expand all subgroups, the group itself is now also automatically expanded.
Previously it was possible to expand all subgroups of a collapsed group, but without expanding the group itself. This needed an extra "expand this group click".

Now the groups deeply check their children whether for expanded/collapsed groups. Previously only the immediate children were checked.

URL of deployed dev instance (used for testing):

Steps to test:

  • open a skeleton tracing
  • test the scenario shown in the picture of the issue Expand and collapse subgroups in trees tab followup #4166. In this specific scenario, it should be possible to still expand all children of the root group.
  • use Expand all subgroups" on a collapsed group. The group itself should now also automatically expand itself.

Issues:


@MichaelBuessemeyer MichaelBuessemeyer changed the title Add collapse all groups Followup fixes for "collapse/expand all subgroups" Jul 26, 2019
@MichaelBuessemeyer MichaelBuessemeyer self-assigned this Jul 26, 2019
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes look very good to me :) I couldn't find a picture in #4162, but I tested the scenarios and fixes you outlined and they worked very well 👍

@MichaelBuessemeyer
Copy link
Contributor Author

MichaelBuessemeyer commented Jul 29, 2019

Sorry, the correct issue is #4166. I updated the description.

@MichaelBuessemeyer MichaelBuessemeyer merged commit fab0905 into master Jul 29, 2019
@normanrz normanrz deleted the add-collapse-all-groups branch August 12, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand and collapse subgroups in trees tab followup
3 participants