Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Bug with Collapse/Expand All Tree Groups #4178

Merged
merged 3 commits into from
Jul 15, 2019
Merged

Fixed Bug with Collapse/Expand All Tree Groups #4178

merged 3 commits into from
Jul 15, 2019

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Jul 11, 2019 •
edited
Loading

This PR fixes the inconsistencies when collapsing/expanding all tree groups or sub-groups introduced by PR #4143. See issue description: #4162

It looks like the expansion state of each node/group is saved in two different places:

  1. The node itself: node.expanded
  2. And in the component's state: `this.state.expandedGroupIds

As far as I can tell, adding expandedGroupIds to the setExpansionOfAllSubgroupsTo solves this issue.

URL of deployed dev instance (used for testing):

Steps to test:

  • Valentin already tested the fix

Issues:

@hotzenklotz hotzenklotz changed the title WIP: Fixed Bug with Collapse/Expand All Tree Groups Fixed Bug with Collapse/Expand All Tree Groups Jul 11, 2019
@hotzenklotz hotzenklotz requested review from daniel-wer and MichaelBuessemeyer and removed request for daniel-wer July 11, 2019 14:18
@hotzenklotz hotzenklotz self-assigned this Jul 11, 2019
@hotzenklotz
Copy link
Member Author

Ready for review

@hotzenklotz hotzenklotz mentioned this pull request Jul 12, 2019
Closed
daniel-wer
daniel-wer approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great find and fix 👍

@hotzenklotz hotzenklotz merged commit 0f96347 into master Jul 15, 2019
@hotzenklotz hotzenklotz deleted the expand_all branch July 15, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

@MichaelBuessemeyer MichaelBuessemeyer Awaiting requested review from MichaelBuessemeyer

Assignees

@hotzenklotz hotzenklotz

Labels
bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toggling tree expands/collapses unrelated subgroups
2 participants
@hotzenklotz @daniel-wer