Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse and Expand all groups feature #4143

Merged
merged 13 commits into from
Jul 2, 2019

Conversation

MichaelBuessemeyer
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer commented Jun 21, 2019

This PR adds two additional buttons to the small dropdown menu of all groups in the tree hierarchy view. These buttons make it possible to collapse and expand all groups.

URL of deployed dev instance (used for testing):

Steps to test:

  • Open a skeleton/hybrid tracing and create some groups and trees. Make sure you also put groups into each other to also test "complex" hierarchies.
  • Use the two new buttons in the dropdown menu of any group. This should collapse or expand all subgroups.

Issues:


Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, really helpful feature :)

I'm not sure whether the location of this button is intuitive and discoverable, though.
@philippotto Do you maybe have a better idea?
Otherwise good to merge as-is :)

@philippotto
Copy link
Member

philippotto commented Jun 24, 2019

Awesome 👍

I'm not sure whether the location of this button is intuitive and discoverable, though.
@philippotto Do you maybe have a better idea?

Georg suggested to use shift (or ctrl) click on the +/- icons of the groups. Not sure, though, how feasible this is with the tree library.

Two things which we could add for this feature:

  • possibility to expand all groups at once (i.e., it would be a toggle button which switches between these two modes)
  • have the collapse/expand functionality per tree group (instead only for the root)

However, I'm fine with the current state, too. The biggest pain point should be already solved by the PR.

@MichaelBuessemeyer MichaelBuessemeyer changed the title Collapse all groups feature Collapse and Expand all groups feature Jun 28, 2019
@MichaelBuessemeyer
Copy link
Contributor Author

Two things which we could add for this feature:

  • possibility to expand all groups at once (i.e., it would be a toggle button which switches between these two modes)
  • have the collapse/expand functionality per tree group (instead only for the root)

@daniel-wer I added the additional thinks mentioned by phillipp.

Could you please check my changes again 🙂

@philippotto

Georg suggested to use shift (or ctrl) click on the +/- icons of the groups. Not sure, though, how feasible this is with the tree library.

Unfortunalty your are right here. The interface of the library does not provide enough information for that. Access to the click event is missing here :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add way to collapse all tree groups
3 participants