-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse and Expand all groups feature #4143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, really helpful feature :)
I'm not sure whether the location of this button is intuitive and discoverable, though.
@philippotto Do you maybe have a better idea?
Otherwise good to merge as-is :)
Awesome 👍
Georg suggested to use shift (or ctrl) click on the +/- icons of the groups. Not sure, though, how feasible this is with the tree library. Two things which we could add for this feature:
However, I'm fine with the current state, too. The biggest pain point should be already solved by the PR. |
…-collapse-all-groups
…bknossos into add-collapse-all-groups
@daniel-wer I added the additional thinks mentioned by phillipp. Could you please check my changes again 🙂
Unfortunalty your are right here. The interface of the library does not provide enough information for that. Access to the click event is missing here :/ |
This PR adds two additional buttons to the small dropdown menu of all groups in the tree hierarchy view. These buttons make it possible to collapse and expand all groups.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
[ ] Updated migration guide if applicable[ ] Adapted wk-connect if datastore API changes[ ] Needs datastore update after deployment