Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sse to multipart upload #3

Merged
merged 18 commits into from
Sep 21, 2024
Merged

add sse to multipart upload #3

merged 18 commits into from
Sep 21, 2024

Conversation

samoii
Copy link
Owner

@samoii samoii commented Sep 14, 2024

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@samoii samoii changed the title add sse to mu,tipart upload add sse to multipart upload Sep 14, 2024
rdettai and others added 16 commits September 16, 2024 13:04
…uickwit-oss#5428)

* Upgrade actions/upload-artifact to match actions/download-artifact

* Separate digests by platform

* Merge artifacts

* Fix artifact name
* add request_timeout config

On very large datasets the fixed timeouts are too low for some queries.
This PR adds a setting to configure the timeout.

Two settings are introduced:
- `request_timeout` on the node config
- `QW_REQUEST_TIMEOUT` env parameter

Currently there are two timeouts when doing a distributed search request, one from quickwit cluster when opening a
channel and one from the search client.
The timeout is applied to both (That means all cluster connections have
the same request_timeout applied, not only search nodes)

Related: quickwit-oss#5241

* move timeout to search config, add timeout tower layer

* cancel search after timeout

* use tokio::timeout

* use global timeoutlayer
* Add test showing bulk order issuer

* Return action responses in same order as request
…uickwit-oss#5438)

The sql that is generated to expand an index name (index_id) into all of
the matching index names uses the LIKE clause to do partial text
matches. However, the only index on the index_id column utilizes the
default btree configuration which can only do exact value comparisons.
In environments with a large search volume over many thousands of
indexes, this can be a bottle neck as the query will always do an full
table scan. This drops and recreates the unique index on index_id
to include the `varchar_pattern_ops` which allows for wildcard
matching on a varchar column using the LIKE operator

Fixes: quickwit-oss#5437
* Garbage collect shards in SQS Filesource

* Run shard pruning in a background task

* Expose deduplication window to users

* Add integration test

* Rename cleanup interval config

* Address smaller review comments

* Change strong_count to Weak

* High level design

* Remove unpure iterators

* Rewrite time operation to rule out underflow

* Remove inappropiate unwrap and fix typo

* Refactor un-necessary deadline_for_last_extension paramter

* Add more details to design document

* Clarify what checkpoint_messages does
* Add debounce to shard prune request

* Use pruning interval as control plane cooldown

* Address smaller review comments

* Simplify debounce logic

* Use LruCache for debounce map

* Refactor and test CooldownMap

* Revert grpc number reuse

* Rename grpc field interval to interval_secs
* Uncomment some tests

* Remove ingest retries

* Fix lint and comment flaky test

* Remove ingest from basic test

* Improve wording

* Ignore test known to be flaky

* Reference issue instead of TODO

* Add back directory cleanup test with link to issue

* Assert shutdown timeout
@samoii samoii merged commit d9c4b8b into aws-s3-sse Sep 21, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants