Upgrade actions/upload-artifact to match actions/download-artifact

[rdettai]

Description

Looks like the bump from actions/download-artifact 3 to 4 broke the docker CI (https://github.com/quickwit-oss/quickwit/actions/workflows/publish_docker_images.yml). This is an expected breaking change (https://github.com/actions/download-artifact?tab=readme-ov-file#breaking-changes))

How was this PR tested?

Describe how you tested this PR.

[rdettai]

In the breaking change section of this new version there is the following item:

Uploading to the same named Artifact multiple times. Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

I think this will likely be a problem as we repeatedly use the same artifact names. But it's not completely clear from the docs whether this restriction applies only within a job run or in general.

[trinity-1686a]

https://github.com/quickwit-oss/quickwit/actions/runs/10879677075

[trinity-1686a]

Run actions/[email protected]
With the provided path, there will be 1 file uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

[github-actions]

On SSD:

Average search latency is 0.994x that of the reference (lower is better).
Ref run id: 3431, ref commit: 2d4f5a6
Link

On GCS:

Average search latency is 0.996x that of the reference (lower is better).
Ref run id: 3432, ref commit: 2d4f5a6
Link

[rdettai]

https://github.com/quickwit-oss/quickwit/actions/runs/10881445673

[rdettai]

https://github.com/quickwit-oss/quickwit/actions/runs/10883228939

[trinity-1686a]

ERROR: can't push with no tags specified, please set --tag or --dry-run

looks like the kind of error we'd expect from running that way, we can ignore it

[rdettai]

looks like the kind of error we'd expect from running that way, we can ignore it

Yes, I was reaching the same conclusion! Let's see what comes out of a merge! (built a small repo https://github.com/rdettai/testartifact to double check upload/download with both versions are now equivalent)