Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade actions/download-artifact from 4.1.8 to 4.1.7 #5427

Closed
wants to merge 1 commit into from

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented Sep 13, 2024

Description

Looks like the bump from 4.1.7 to 4.1.8 (#5410) broke the docker CI (https://github.com/quickwit-oss/quickwit/actions/workflows/publish_docker_images.yml). I didn't investigate why.

How was this PR tested?

@rdettai rdettai self-assigned this Sep 13, 2024
@rdettai rdettai requested review from guilload and removed request for guilload September 13, 2024 15:35
Copy link

On SSD:

Average search latency is 0.991x that of the reference (lower is better).
Ref run id: 3417, ref commit: 8988310
Link

On GCS:

Average search latency is 1.05x that of the reference (lower is better).
Ref run id: 3418, ref commit: 8988310
Link

@trinity-1686a
Copy link
Contributor

the pipeline on b61ba35 failed too, that was just after 3->4.1.7, but before 4.1.7->4.1.8 , so I don't think this actually fixes the issue.
I see a uses: actions/upload-artifact@v3 a few line before. I'm not familiar with actions, but i would guess a missmatch of major version between upload-artifact and download-artifact could easily break things

@rdettai
Copy link
Contributor Author

rdettai commented Sep 16, 2024

You are right, I didn't notice there was a bump 3->4 right before! Indeed, uploads from 3 are not compatible with dowloads from 4 (https://github.com/actions/download-artifact?tab=readme-ov-file#breaking-changes)

@rdettai rdettai closed this Sep 16, 2024
@rdettai rdettai deleted the revert-artifact-action-upgrade branch September 16, 2024 07:46
@rdettai
Copy link
Contributor Author

rdettai commented Sep 16, 2024

Superseeded by #5428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants