Cleanup integration tests #5429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,30 +162,5 @@ async fn test_multi_nodes_cluster() { | |||
| .unwrap(); | |||
| assert_eq!(search_response_empty.num_hits, 0); | |||
|
|
|||
| // Check that ingest request send to searcher is forwarded to indexer and thus indexed. | |||
There was a problem hiding this comment.
why is this getting removed? That seems like a reasonable test case
There was a problem hiding this comment.
Ingest is tested from many angles in the dedicated ingest_tests.rs. I want basic_tests.rs to focus on basic cluster functions (start, healthchecks, empty cluster state).
rdettai
force-pushed
the
cleanup-integ-tests
branch
from
ac162bc to
23b9fe7
Compare
trinity-1686a
approved these changes
Sep 19, 2024
rdettai
force-pushed
the
cleanup-integ-tests
branch
from
23b9fe7 to
ee66453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uncomment some tests and remove some outdated workarounds in the integration tests:
ingest_tests)How was this PR tested?
Describe how you tested this PR.