Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cherry pick changes for 0.39.1-222.1 #1223

Merged
merged 8 commits into from
May 10, 2019
Merged

chore: cherry pick changes for 0.39.1-222.1 #1223

merged 8 commits into from
May 10, 2019

Conversation

ekashida
Copy link
Member

Details

See individual commits.

Does this PR introduce a breaking change?

No

caridy and others added 8 commits May 9, 2019 17:47
@caridy @ekashida
fix(engine): fixes #1199 and #1198 - disconnecting bug (#1202) (#1209)
657c73b 
* fix(engine): issues #1199 and #1198 when disconnecting

* fix(engine): PR 1202 feedback

* fix(engine): undefined elm needs protection

* fix(engine): adding tests for PR 1202

* fix(engine): test fix for native shadow
@ravijayaramappa @ekashida
fix: refactor mutation observer polyfill to fix memory leaks (#1200)
41bce87 
* fix: refactor mutation observer polyfill to fix memory leaks

* fix: address pr feedback
@jodarove @ekashida
test(integration-karma): migrate nested-template-event-target (#1207)
40905e7 
* test(integration-karma): migrate nested-template-event-target

* test(integration-karma): migrate root-listener-event-target

* test(integration-karma): migrate slotted-custome-element-event-target

* test(integration-karma): migrate nested-render-conditional

* test: increase timeout for two tests that flap in ie11
@caridy @ekashida
fix(synthetic-shadow): types and bugs in preparation for final split (#…
c4f431d 
…1192)

* fix(synthetic-shadow): types and bugs

* fix(synthetic-shadow): activeElement only works if patch on doc

* fix(synthetic-shadow): PR 1192 feedback

* fix(synthetic-shadow): bug fix for async retargeting
@ekashida
fix: prevent tabbing into subtrees with tabindex -1 (#1206)
d5752b6 
* test: adjust tests to reproduce issue

* refactor: tabIndex setter comment

* refactor: keyboard focus handling relative to current context

* test: failing test for internal negative tabindex

* fix: correct tabbing when negative tabindex in zero tabindex

* chore: remove .only

* chore: use getOwnerDocument instead of ownerDocumentGetter

* chore: refactor test to use blocking selenium api
@jodarove @ekashida
test(integration-karma): migrate misc tests from integration-test (#1212
ee640f1 
)

* test(integration-karma): migrate non-composed-events-on-custom-element

* test(integration-karma): migrate events/slotted-native-element

* test(integration-karma): migrate events/window-event-listiner

* test(integration-karma): roolback migrate window-event-listener

* test(integration-karma): migrate rendering/duplicate-text-rendering

* test(integration-karma): migrate rendering/form-tag

* test(integration-karma): migrate rendering/nested-state

* test(integration-karma): migrate rendering/null-logging
@ekashida
feat(babel): add filename/location to error (#1208)
f60210e 
* feat(babel): add filename/location to error

* wip: fix tests

* wip: return consistent location object

* wip: review comments
@ravijayaramappa @ekashida
fix: provide a way to disable document patching (#1221)
94a816b 
* fix: provide a way to disable document patching

* fix: update names and move function out
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: a7c563e | Target commit: 94a816b

lwc-engine-benchmark

table-append-1k metric base(a7c563e) target(94a816b) trend
benchmark-table/append/1k duration 150.55 (±4.40 ms) 149.85 (±3.50 ms) -0.7ms (0.5%) 👌
table-clear-1k metric base(a7c563e) target(94a816b) trend
benchmark-table/clear/1k duration 11.85 (±0.75 ms) 12.00 (±0.85 ms) +0.1ms (1.3%) 👌
table-create-10k metric base(a7c563e) target(94a816b) trend
benchmark-table/create/10k duration 910.45 (±5.75 ms) 884.65 (±5.20 ms) -25.8ms (2.8%) 👍
table-create-1k metric base(a7c563e) target(94a816b) trend
benchmark-table/create/1k duration 120.45 (±2.80 ms) 118.15 (±2.75 ms) -2.3ms (1.9%) 👍
table-update-10th-1k metric base(a7c563e) target(94a816b) trend
benchmark-table/update-10th/1k duration 68.70 (±1.95 ms) 68.80 (±1.55 ms) +0.1ms (0.1%) 👌
tablecmp-append-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-component/append/1k duration 223.40 (±8.15 ms) 229.10 (±10.45 ms) +5.7ms (2.6%) 👌
tablecmp-clear-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-component/clear/1k duration 6.40 (±1.20 ms) 7.40 (±1.35 ms) +1.0ms (15.6%) 👎
tablecmp-create-10k metric base(a7c563e) target(94a816b) trend
benchmark-table-component/create/10k duration 1751.15 (±9.40 ms) 1739.80 (±15.10 ms) -11.4ms (0.6%) 👍
tablecmp-create-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-component/create/1k duration 212.30 (±5.00 ms) 210.60 (±5.35 ms) -1.7ms (0.8%) 👌
tablecmp-update-10th-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-component/update-10th/1k duration 65.70 (±5.20 ms) 66.15 (±3.80 ms) +0.5ms (0.7%) 👌
wc-append-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-wc/append/1k duration 232.60 (±12.65 ms) 230.40 (±15.75 ms) -2.2ms (0.9%) 👌
wc-clear-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-wc/clear/1k duration 11.80 (±1.60 ms) 11.20 (±1.80 ms) -0.6ms (5.1%) 👌
wc-create-10k metric base(a7c563e) target(94a816b) trend
benchmark-table-wc/create/10k duration 1889.15 (±15.55 ms) 1899.25 (±15.90 ms) +10.1ms (0.5%) 👌
wc-create-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-wc/create/1k duration 218.25 (±5.60 ms) 222.10 (±3.35 ms) +3.8ms (1.8%) 👎
wc-update-10th-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-wc/update-10th/1k duration 68.10 (±4.80 ms) 68.40 (±5.55 ms) +0.3ms (0.4%) 👌

@ekashida ekashida merged commit 7b71ae4 into 0.39.1-222 May 10, 2019
@ekashida ekashida deleted the ekashida/0.39.1-222.1 branch May 10, 2019 01:15
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: a7c563e | Target commit: 94a816b

lwc-engine-benchmark

table-append-1k metric base(a7c563e) target(94a816b) trend
benchmark-table/append/1k duration 150.55 (±4.40 ms) 149.50 (±4.85 ms) -1.1ms (0.7%) 👌
table-clear-1k metric base(a7c563e) target(94a816b) trend
benchmark-table/clear/1k duration 11.85 (±0.75 ms) 11.70 (±0.65 ms) -0.2ms (1.3%) 👌
table-create-10k metric base(a7c563e) target(94a816b) trend
benchmark-table/create/10k duration 910.45 (±5.75 ms) 880.60 (±4.30 ms) -29.9ms (3.3%) 👍
table-create-1k metric base(a7c563e) target(94a816b) trend
benchmark-table/create/1k duration 120.45 (±2.80 ms) 120.10 (±3.35 ms) -0.4ms (0.3%) 👌
table-update-10th-1k metric base(a7c563e) target(94a816b) trend
benchmark-table/update-10th/1k duration 68.70 (±1.95 ms) 69.15 (±2.00 ms) +0.5ms (0.7%) 👌
tablecmp-append-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-component/append/1k duration 223.40 (±8.15 ms) 230.80 (±13.85 ms) +7.4ms (3.3%) 👌
tablecmp-clear-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-component/clear/1k duration 6.40 (±1.20 ms) 7.10 (±1.50 ms) +0.7ms (10.9%) 👌
tablecmp-create-10k metric base(a7c563e) target(94a816b) trend
benchmark-table-component/create/10k duration 1751.15 (±9.40 ms) 1737.25 (±12.85 ms) -13.9ms (0.8%) 👍
tablecmp-create-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-component/create/1k duration 212.30 (±5.00 ms) 212.90 (±5.85 ms) +0.6ms (0.3%) 👌
tablecmp-update-10th-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-component/update-10th/1k duration 65.70 (±5.20 ms) 66.00 (±5.70 ms) +0.3ms (0.5%) 👌
wc-append-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-wc/append/1k duration 232.60 (±12.65 ms) 232.35 (±16.05 ms) -0.3ms (0.1%) 👌
wc-clear-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-wc/clear/1k duration 11.80 (±1.60 ms) 11.80 (±1.45 ms) 0.0ms (0.0%) 👌
wc-create-10k metric base(a7c563e) target(94a816b) trend
benchmark-table-wc/create/10k duration 1889.15 (±15.55 ms) 1904.55 (±15.80 ms) +15.4ms (0.8%) 👎
wc-create-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-wc/create/1k duration 218.25 (±5.60 ms) 217.65 (±4.80 ms) -0.6ms (0.3%) 👌
wc-update-10th-1k metric base(a7c563e) target(94a816b) trend
benchmark-table-wc/update-10th/1k duration 68.10 (±4.80 ms) 68.85 (±4.80 ms) +0.8ms (1.1%) 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ekashida @caridy @ravijayaramappa @jodarove