test(integration-karma): migrate misc tests from integration-test #1212

jodarove · 2019-05-07T21:51:31Z

Details

events/non-composed-events-on-custom-element
events/slotted-native-element
events/window-event-listener
rendering/duplicate-text-rendering
rendering/form-tag
migrate rendering/nested-state
migrate rendering/null-logging

Does this PR introduce a breaking change?

Yes
No

salesforce-best-lwc-internal · 2019-05-07T22:16:57Z

Benchmark results

Base commit: 6d2de54 | Target commit: eee894f

lwc-engine-benchmark

table-append-1k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table/append/1k	duration	150.60 (±4.05 ms)	152.20 (±4.30 ms)	+1.6ms (1.1%) 👌

table-clear-1k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table/clear/1k	duration	11.50 (±0.60 ms)	12.10 (±0.60 ms)	+0.6ms (5.2%) 👌

table-create-10k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table/create/10k	duration	909.50 (±6.85 ms)	904.50 (±5.05 ms)	-5.0ms (0.5%) 👍

table-create-1k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table/create/1k	duration	119.95 (±2.45 ms)	118.80 (±2.80 ms)	-1.1ms (1.0%) 👌

table-update-10th-1k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table/update-10th/1k	duration	70.00 (±2.15 ms)	69.75 (±2.45 ms)	-0.3ms (0.4%) 👌

tablecmp-append-1k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table-component/append/1k	duration	225.20 (±12.55 ms)	228.35 (±7.85 ms)	+3.2ms (1.4%) 👌

tablecmp-clear-1k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table-component/clear/1k	duration	7.50 (±1.35 ms)	7.10 (±1.20 ms)	-0.4ms (5.3%) 👌

tablecmp-create-10k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table-component/create/10k	duration	1740.25 (±14.05 ms)	1770.80 (±15.65 ms)	+30.5ms (1.8%) 👎

tablecmp-create-1k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table-component/create/1k	duration	213.85 (±5.25 ms)	216.55 (±7.70 ms)	+2.7ms (1.3%) 👌

tablecmp-update-10th-1k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table-component/update-10th/1k	duration	66.80 (±4.35 ms)	65.90 (±4.10 ms)	-0.9ms (1.3%) 👌

wc-append-1k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table-wc/append/1k	duration	233.05 (±15.20 ms)	226.25 (±15.70 ms)	-6.8ms (2.9%) 👌

wc-clear-1k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table-wc/clear/1k	duration	12.20 (±1.95 ms)	12.40 (±1.30 ms)	+0.2ms (1.6%) 👌

wc-create-10k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table-wc/create/10k	duration	1883.25 (±23.30 ms)	1858.65 (±23.85 ms)	-24.6ms (1.3%) 👍

wc-create-1k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table-wc/create/1k	duration	218.50 (±4.30 ms)	220.80 (±4.95 ms)	+2.3ms (1.1%) 👌

wc-update-10th-1k	metric	base(`6d2de54`)	target(`eee894f`)	trend
benchmark-table-wc/update-10th/1k	duration	67.75 (±4.75 ms)	68.45 (±4.05 ms)	+0.7ms (1.0%) 👌

salesforce-best-lwc-internal · 2019-05-07T23:35:32Z

Benchmark results

Base commit: 9f273f5 | Target commit: ae94779

lwc-engine-benchmark

table-append-1k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table/append/1k	duration	152.70 (±3.85 ms)	153.95 (±5.05 ms)	+1.3ms (0.8%) 👌

table-clear-1k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table/clear/1k	duration	11.60 (±1.10 ms)	12.10 (±0.80 ms)	+0.5ms (4.3%) 👌

table-create-10k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table/create/10k	duration	895.55 (±5.75 ms)	908.95 (±6.70 ms)	+13.4ms (1.5%) 👎

table-create-1k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table/create/1k	duration	120.75 (±2.90 ms)	118.95 (±3.00 ms)	-1.8ms (1.5%) 👍

table-update-10th-1k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table/update-10th/1k	duration	69.50 (±1.85 ms)	78.05 (±2.90 ms)	+8.5ms (12.3%) 👎

tablecmp-append-1k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table-component/append/1k	duration	225.30 (±7.15 ms)	227.05 (±8.25 ms)	+1.8ms (0.8%) 👌

tablecmp-clear-1k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table-component/clear/1k	duration	6.85 (±1.40 ms)	7.30 (±1.30 ms)	+0.5ms (6.6%) 👌

tablecmp-create-10k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table-component/create/10k	duration	1764.55 (±17.25 ms)	1750.60 (±17.85 ms)	-14.0ms (0.8%) 👍

tablecmp-create-1k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table-component/create/1k	duration	214.85 (±5.80 ms)	212.65 (±4.60 ms)	-2.2ms (1.0%) 👌

tablecmp-update-10th-1k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table-component/update-10th/1k	duration	65.95 (±4.85 ms)	67.90 (±4.80 ms)	+2.0ms (3.0%) 👌

wc-append-1k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table-wc/append/1k	duration	232.80 (±15.45 ms)	226.25 (±18.10 ms)	-6.6ms (2.8%) 👌

wc-clear-1k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table-wc/clear/1k	duration	11.70 (±1.45 ms)	12.50 (±1.50 ms)	+0.8ms (6.8%) 👎

wc-create-10k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table-wc/create/10k	duration	1875.05 (±19.30 ms)	1895.00 (±25.15 ms)	+20.0ms (1.1%) 👎

wc-create-1k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table-wc/create/1k	duration	218.35 (±4.05 ms)	219.70 (±7.30 ms)	+1.3ms (0.6%) 👌

wc-update-10th-1k	metric	base(`9f273f5`)	target(`ae94779`)	trend
benchmark-table-wc/update-10th/1k	duration	67.95 (±4.75 ms)	69.95 (±5.15 ms)	+2.0ms (2.9%) 👌

// The composed-event-click-polyfill doesn't work when native Shadow DOM is enabled on Safari 12.0.0 (it has been fixed // with Safari 12.0.1). The polyfill only patches the event javascript wrapper and doesn't have any effect on how Webkit // make the event bubbles.

caridy

LGTM

jodarove · 2019-05-09T00:04:14Z

Ill merge this pr, currently failing:

perf_compare (for all prs)
and one flapper in compat with error:

------------------------------------------------------------------
[internet explorer 11.103 Windows 10 #0-28] Session ID: 76503e1092854238b189751084bf190f
[internet explorer 11.103 Windows 10 #0-28] Spec: /home/circleci/lwc/packages/integration-tests/src/components/delegates-focus-tab-navigation/test-tabindex-toggle/tabindex-toggle.spec.js
[internet explorer 11.103 Windows 10 #0-28] Running: internet explorer (v11.103) on Windows 10
[internet explorer 11.103 Windows 10 #0-28]
[internet explorer 11.103 Windows 10 #0-28] [PROD_COMPAT] Tab navigation without tabindex
[internet explorer 11.103 Windows 10 #0-28] [PROD_COMPAT]   1) should support tabindex toggling
[internet explorer 11.103 Windows 10 #0-28] [PROD_COMPAT]
[internet explorer 11.103 Windows 10 #0-28]
[internet explorer 11.103 Windows 10 #0-28] 1 failing (28s)
[internet explorer 11.103 Windows 10 #0-28]
[internet explorer 11.103 Windows 10 #0-28] 1) Tab navigation without tabindex should support tabindex toggling:
[internet explorer 11.103 Windows 10 #0-28] Timeout of 10000ms exceeded. Try to reduce the run time or increase your timeout for test specs (http://webdriver.io/guide/testrunner/timeouts.html); if returning a Promise, ensure it resolves. (/home/circleci/lwc/packages/integration-tests/src/components/delegates-focus-tab-navigation/test-tabindex-toggle/tabindex-toggle.spec.js)
[internet explorer 11.103 Windows 10 #0-28] Error: Timeout of 10000ms exceeded. Try to reduce the run time or increase your timeout for test specs (http://webdriver.io/guide/testrunner/timeouts.html); if returning a Promise, ensure it resolves. (/home/circleci/lwc/packages/integration-tests/src/components/delegates-focus-tab-navigation/test-tabindex-toggle/tabindex-toggle.spec.js)
[internet explorer 11.103 Windows 10 #0-28]     at Test.Runnable._timeoutError (/home/circleci/lwc/node_modules/mocha/lib/runnable.js:440:10)
[internet explorer 11.103 Windows 10 #0-28]     at Timeout.<anonymous> (/home/circleci/lwc/node_modules/mocha/lib/runnable.js:251:24)
[internet explorer 11.103 Windows 10 #0-28]     at ontimeout (timers.js:436:11)
[internet explorer 11.103 Windows 10 #0-28]     at tryOnTimeout (timers.js:300:5)
[internet explorer 11.103 Windows 10 #0-28]     at listOnTimeout (timers.js:263:5)
[internet explorer 11.103 Windows 10 #0-28]     at Timer.processTimers (timers.js:223:10)
[internet explorer 11.103 Windows 10 #0-28]
[internet explorer 11.103 Windows 10 #0-28] Check out job at https://saucelabs.com/tests/76503e1092854238b189751084bf190f
[internet explorer 11.103 Windows 10 #0-28]

) * test(integration-karma): migrate non-composed-events-on-custom-element * test(integration-karma): migrate events/slotted-native-element * test(integration-karma): migrate events/window-event-listiner * test(integration-karma): roolback migrate window-event-listener * test(integration-karma): migrate rendering/duplicate-text-rendering * test(integration-karma): migrate rendering/form-tag * test(integration-karma): migrate rendering/nested-state * test(integration-karma): migrate rendering/null-logging

* fix(engine): fixes #1199 and #1198 - disconnecting bug (#1202) (#1209) * fix(engine): issues #1199 and #1198 when disconnecting * fix(engine): PR 1202 feedback * fix(engine): undefined elm needs protection * fix(engine): adding tests for PR 1202 * fix(engine): test fix for native shadow * fix: refactor mutation observer polyfill to fix memory leaks (#1200) * fix: refactor mutation observer polyfill to fix memory leaks * fix: address pr feedback * test(integration-karma): migrate nested-template-event-target (#1207) * test(integration-karma): migrate nested-template-event-target * test(integration-karma): migrate root-listener-event-target * test(integration-karma): migrate slotted-custome-element-event-target * test(integration-karma): migrate nested-render-conditional * test: increase timeout for two tests that flap in ie11 * fix(synthetic-shadow): types and bugs in preparation for final split (#1192) * fix(synthetic-shadow): types and bugs * fix(synthetic-shadow): activeElement only works if patch on doc * fix(synthetic-shadow): PR 1192 feedback * fix(synthetic-shadow): bug fix for async retargeting * fix: prevent tabbing into subtrees with tabindex -1 (#1206) * test: adjust tests to reproduce issue * refactor: tabIndex setter comment * refactor: keyboard focus handling relative to current context * test: failing test for internal negative tabindex * fix: correct tabbing when negative tabindex in zero tabindex * chore: remove .only * chore: use getOwnerDocument instead of ownerDocumentGetter * chore: refactor test to use blocking selenium api * test(integration-karma): migrate misc tests from integration-test (#1212) * test(integration-karma): migrate non-composed-events-on-custom-element * test(integration-karma): migrate events/slotted-native-element * test(integration-karma): migrate events/window-event-listiner * test(integration-karma): roolback migrate window-event-listener * test(integration-karma): migrate rendering/duplicate-text-rendering * test(integration-karma): migrate rendering/form-tag * test(integration-karma): migrate rendering/nested-state * test(integration-karma): migrate rendering/null-logging * feat(babel): add filename/location to error (#1208) * feat(babel): add filename/location to error * wip: fix tests * wip: return consistent location object * wip: review comments * fix: provide a way to disable document patching (#1221) * fix: provide a way to disable document patching * fix: update names and move function out

) * test(integration-karma): migrate non-composed-events-on-custom-element * test(integration-karma): migrate events/slotted-native-element * test(integration-karma): migrate events/window-event-listiner * test(integration-karma): roolback migrate window-event-listener * test(integration-karma): migrate rendering/duplicate-text-rendering * test(integration-karma): migrate rendering/form-tag * test(integration-karma): migrate rendering/nested-state * test(integration-karma): migrate rendering/null-logging

jodarove added the work-in-progress Work in progress label May 7, 2019

jodarove added 8 commits May 8, 2019 10:25

test(integration-karma): migrate non-composed-events-on-custom-element

dc2c125

test(integration-karma): migrate events/slotted-native-element

746fd95

test(integration-karma): migrate events/window-event-listiner

b1f3d45

test(integration-karma): migrate rendering/duplicate-text-rendering

4399a07

test(integration-karma): migrate rendering/form-tag

27c43fa

test(integration-karma): migrate rendering/nested-state

f8e4634

test(integration-karma): migrate rendering/null-logging

5a70194

jodarove force-pushed the jodarove/migrate-test-karma branch from 27bd180 to 5a70194 Compare May 8, 2019 17:33

jodarove removed the work-in-progress Work in progress label May 8, 2019

caridy approved these changes May 8, 2019

View reviewed changes

jodarove merged commit b368901 into master May 9, 2019

jodarove deleted the jodarove/migrate-test-karma branch May 9, 2019 00:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(integration-karma): migrate misc tests from integration-test #1212

test(integration-karma): migrate misc tests from integration-test #1212

jodarove commented May 7, 2019 •

edited

Loading

salesforce-best-lwc-internal bot commented May 7, 2019

salesforce-best-lwc-internal bot commented May 7, 2019

caridy left a comment

jodarove commented May 9, 2019

test(integration-karma): migrate misc tests from integration-test #1212

test(integration-karma): migrate misc tests from integration-test #1212

Conversation

jodarove commented May 7, 2019 • edited Loading

Details

Does this PR introduce a breaking change?

salesforce-best-lwc-internal bot commented May 7, 2019

Benchmark results

lwc-engine-benchmark

salesforce-best-lwc-internal bot commented May 7, 2019

Benchmark results

lwc-engine-benchmark

caridy left a comment

Choose a reason for hiding this comment

jodarove commented May 9, 2019

jodarove commented May 7, 2019 •

edited

Loading