fix(synthetic-shadow): types and bugs in preparation for final split #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pmdartus
reviewed
Apr 23, 2019
| ? Document.prototype.elementFromPoint | ||
| : (Document.prototype as any).msElementFromPoint; // IE11 | ||
|
|
||
| // TODO: when does defaultView return a null? | ||
| const defaultViewGetter: (this: Document) => Window = getOwnPropertyDescriptor( |
There was a problem hiding this comment.
defaultView is null when a document has no browsing context. A good example is the owner document of a node in a template doesn't have a default view. Here is an example: https://jsfiddle.net/hv9z0q5a/
There was a problem hiding this comment.
great, I will update the PR to take that into account, I wasn't sure.
ekashida
approved these changes
Apr 25, 2019
ravijayaramappa
approved these changes
Apr 25, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Ok ,we are down to 5 integration compat tests in IE11: 81 passing (366.70s)
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
commented
Apr 27, 2019
| const toggleElement = browser.execute(function() { | ||
| return document | ||
| .querySelector('integration-nested-render-conditional') | ||
| .shadowRoot.querySelectorAll('.toggle'); |
There was a problem hiding this comment.
@jodarove any particular reason for doing querySelector instead of querySelectorAll? it looks ok, just curious.
There was a problem hiding this comment.
the test was checking that there were no element in the array (value.length). since values is the wdio property, i think is more readable/stable if we test that value is null (no element returned)
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
|
We still have few flappers here, but we will move forward, @jodarove will fix them in another PR. |
ekashida
pushed a commit
that referenced
this pull request
May 10, 2019
…1192) * fix(synthetic-shadow): types and bugs * fix(synthetic-shadow): activeElement only works if patch on doc * fix(synthetic-shadow): PR 1192 feedback * fix(synthetic-shadow): bug fix for async retargeting
ekashida
added a commit
that referenced
this pull request
May 10, 2019
* fix(engine): fixes #1199 and #1198 - disconnecting bug (#1202) (#1209) * fix(engine): issues #1199 and #1198 when disconnecting * fix(engine): PR 1202 feedback * fix(engine): undefined elm needs protection * fix(engine): adding tests for PR 1202 * fix(engine): test fix for native shadow * fix: refactor mutation observer polyfill to fix memory leaks (#1200) * fix: refactor mutation observer polyfill to fix memory leaks * fix: address pr feedback * test(integration-karma): migrate nested-template-event-target (#1207) * test(integration-karma): migrate nested-template-event-target * test(integration-karma): migrate root-listener-event-target * test(integration-karma): migrate slotted-custome-element-event-target * test(integration-karma): migrate nested-render-conditional * test: increase timeout for two tests that flap in ie11 * fix(synthetic-shadow): types and bugs in preparation for final split (#1192) * fix(synthetic-shadow): types and bugs * fix(synthetic-shadow): activeElement only works if patch on doc * fix(synthetic-shadow): PR 1192 feedback * fix(synthetic-shadow): bug fix for async retargeting * fix: prevent tabbing into subtrees with tabindex -1 (#1206) * test: adjust tests to reproduce issue * refactor: tabIndex setter comment * refactor: keyboard focus handling relative to current context * test: failing test for internal negative tabindex * fix: correct tabbing when negative tabindex in zero tabindex * chore: remove .only * chore: use getOwnerDocument instead of ownerDocumentGetter * chore: refactor test to use blocking selenium api * test(integration-karma): migrate misc tests from integration-test (#1212) * test(integration-karma): migrate non-composed-events-on-custom-element * test(integration-karma): migrate events/slotted-native-element * test(integration-karma): migrate events/window-event-listiner * test(integration-karma): roolback migrate window-event-listener * test(integration-karma): migrate rendering/duplicate-text-rendering * test(integration-karma): migrate rendering/form-tag * test(integration-karma): migrate rendering/nested-state * test(integration-karma): migrate rendering/null-logging * feat(babel): add filename/location to error (#1208) * feat(babel): add filename/location to error * wip: fix tests * wip: return consistent location object * wip: review comments * fix: provide a way to disable document patching (#1221) * fix: provide a way to disable document patching * fix: update names and move function out
ekashida
pushed a commit
that referenced
this pull request
May 14, 2019
…1192) * fix(synthetic-shadow): types and bugs * fix(synthetic-shadow): activeElement only works if patch on doc * fix(synthetic-shadow): PR 1192 feedback * fix(synthetic-shadow): bug fix for async retargeting
ekashida
pushed a commit
that referenced
this pull request
May 14, 2019
…1192) * fix(synthetic-shadow): types and bugs * fix(synthetic-shadow): activeElement only works if patch on doc * fix(synthetic-shadow): PR 1192 feedback * fix(synthetic-shadow): bug fix for async retargeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
documentandwindowdirectly from function bodies because they are bound to a closure, and JSDOM shares these functions between workers (this will help in the future)Does this PR introduce a breaking change?