Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(integration-karma): migrate nested-template-event-target #1207

Merged
merged 5 commits into from
May 4, 2019

Conversation

jodarove
Copy link
Contributor

@jodarove jodarove commented May 3, 2019

Details

Migrates integration tests to karma:

  • test nested template event target
  • root-listener-event-target
  • slotted-custome-element-event-target
  • nested-render-conditional

Does this PR introduce a breaking change?

  • Yes
  • No

@jodarove jodarove added the work-in-progress Work in progress label May 3, 2019
@jodarove jodarove force-pushed the jodarove/migrate-ie11-flapers branch from a446a63 to f391d45 Compare May 3, 2019 20:45
@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: e42e0db | Target commit: 23a3638

lwc-engine-benchmark

table-append-1k metric base(e42e0db) target(23a3638) trend
benchmark-table/append/1k duration 152.50 (±4.40 ms) 149.80 (±5.75 ms) -2.7ms (1.8%) 👌
table-clear-1k metric base(e42e0db) target(23a3638) trend
benchmark-table/clear/1k duration 11.55 (±0.70 ms) 12.10 (±1.00 ms) +0.5ms (4.8%) 👌
table-create-10k metric base(e42e0db) target(23a3638) trend
benchmark-table/create/10k duration 904.75 (±5.85 ms) 928.20 (±7.95 ms) +23.5ms (2.6%) 👎
table-create-1k metric base(e42e0db) target(23a3638) trend
benchmark-table/create/1k duration 119.95 (±2.75 ms) 119.35 (±2.40 ms) -0.6ms (0.5%) 👌
table-update-10th-1k metric base(e42e0db) target(23a3638) trend
benchmark-table/update-10th/1k duration 78.90 (±1.25 ms) 78.70 (±1.60 ms) -0.2ms (0.3%) 👌
tablecmp-append-1k metric base(e42e0db) target(23a3638) trend
benchmark-table-component/append/1k duration 234.85 (±11.80 ms) 233.35 (±15.45 ms) -1.5ms (0.6%) 👌
tablecmp-clear-1k metric base(e42e0db) target(23a3638) trend
benchmark-table-component/clear/1k duration 6.40 (±0.95 ms) 6.45 (±1.10 ms) +0.0ms (0.8%) 👌
tablecmp-create-10k metric base(e42e0db) target(23a3638) trend
benchmark-table-component/create/10k duration 1742.35 (±12.25 ms) 1739.10 (±13.90 ms) -3.3ms (0.2%) 👌
tablecmp-create-1k metric base(e42e0db) target(23a3638) trend
benchmark-table-component/create/1k duration 215.00 (±5.40 ms) 211.95 (±5.20 ms) -3.1ms (1.4%) 👍
tablecmp-update-10th-1k metric base(e42e0db) target(23a3638) trend
benchmark-table-component/update-10th/1k duration 67.65 (±4.95 ms) 64.70 (±4.25 ms) -3.0ms (4.4%) 👍
wc-append-1k metric base(e42e0db) target(23a3638) trend
benchmark-table-wc/append/1k duration 231.10 (±19.15 ms) 232.25 (±18.85 ms) +1.2ms (0.5%) 👌
wc-clear-1k metric base(e42e0db) target(23a3638) trend
benchmark-table-wc/clear/1k duration 11.35 (±1.45 ms) 11.05 (±1.65 ms) -0.3ms (2.6%) 👌
wc-create-10k metric base(e42e0db) target(23a3638) trend
benchmark-table-wc/create/10k duration 1898.95 (±14.55 ms) 1896.55 (±20.75 ms) -2.4ms (0.1%) 👌
wc-create-1k metric base(e42e0db) target(23a3638) trend
benchmark-table-wc/create/1k duration 217.75 (±4.25 ms) 215.45 (±4.60 ms) -2.3ms (1.1%) 👍
wc-update-10th-1k metric base(e42e0db) target(23a3638) trend
benchmark-table-wc/update-10th/1k duration 68.65 (±5.25 ms) 66.65 (±5.25 ms) -2.0ms (2.9%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: c2b68ed | Target commit: 251357f

lwc-engine-benchmark

table-append-1k metric base(c2b68ed) target(251357f) trend
benchmark-table/append/1k duration 150.30 (±4.30 ms) 150.70 (±5.30 ms) +0.4ms (0.3%) 👌
table-clear-1k metric base(c2b68ed) target(251357f) trend
benchmark-table/clear/1k duration 11.45 (±0.80 ms) 11.95 (±0.75 ms) +0.5ms (4.4%) 👎
table-create-10k metric base(c2b68ed) target(251357f) trend
benchmark-table/create/10k duration 886.50 (±6.00 ms) 891.40 (±4.60 ms) +4.9ms (0.6%) 👎
table-create-1k metric base(c2b68ed) target(251357f) trend
benchmark-table/create/1k duration 119.10 (±3.70 ms) 117.50 (±2.40 ms) -1.6ms (1.3%) 👌
table-update-10th-1k metric base(c2b68ed) target(251357f) trend
benchmark-table/update-10th/1k duration 69.75 (±2.80 ms) 77.15 (±2.75 ms) +7.4ms (10.6%) 👎
tablecmp-append-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-component/append/1k duration 231.15 (±10.20 ms) 227.90 (±11.05 ms) -3.2ms (1.4%) 👌
tablecmp-clear-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-component/clear/1k duration 7.20 (±1.00 ms) 6.35 (±1.15 ms) -0.9ms (11.8%) 👍
tablecmp-create-10k metric base(c2b68ed) target(251357f) trend
benchmark-table-component/create/10k duration 1760.80 (±15.70 ms) 1732.30 (±13.60 ms) -28.5ms (1.6%) 👍
tablecmp-create-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-component/create/1k duration 213.90 (±5.80 ms) 216.95 (±5.00 ms) +3.0ms (1.4%) 👎
tablecmp-update-10th-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-component/update-10th/1k duration 66.65 (±4.95 ms) 67.30 (±4.55 ms) +0.6ms (1.0%) 👌
wc-append-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-wc/append/1k duration 231.15 (±16.45 ms) 231.25 (±18.55 ms) +0.1ms (0.0%) 👌
wc-clear-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-wc/clear/1k duration 12.65 (±1.80 ms) 11.55 (±1.35 ms) -1.1ms (8.7%) 👍
wc-create-10k metric base(c2b68ed) target(251357f) trend
benchmark-table-wc/create/10k duration 1873.20 (±21.60 ms) 1854.30 (±14.25 ms) -18.9ms (1.0%) 👍
wc-create-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-wc/create/1k duration 219.45 (±4.45 ms) 216.45 (±5.90 ms) -3.0ms (1.4%) 👍
wc-update-10th-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-wc/update-10th/1k duration 66.05 (±4.05 ms) 71.10 (±7.15 ms) +5.0ms (7.6%) 👌

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: c2b68ed | Target commit: 251357f

lwc-engine-benchmark

table-append-1k metric base(c2b68ed) target(251357f) trend
benchmark-table/append/1k duration 150.30 (±4.30 ms) 152.10 (±3.50 ms) +1.8ms (1.2%) 👌
table-clear-1k metric base(c2b68ed) target(251357f) trend
benchmark-table/clear/1k duration 11.45 (±0.80 ms) 11.95 (±0.85 ms) +0.5ms (4.4%) 👌
table-create-10k metric base(c2b68ed) target(251357f) trend
benchmark-table/create/10k duration 886.50 (±6.00 ms) 899.00 (±7.25 ms) +12.5ms (1.4%) 👎
table-create-1k metric base(c2b68ed) target(251357f) trend
benchmark-table/create/1k duration 119.10 (±3.70 ms) 118.95 (±3.10 ms) -0.2ms (0.1%) 👌
table-update-10th-1k metric base(c2b68ed) target(251357f) trend
benchmark-table/update-10th/1k duration 69.75 (±2.80 ms) 68.45 (±2.10 ms) -1.3ms (1.9%) 👍
tablecmp-append-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-component/append/1k duration 231.15 (±10.20 ms) 228.55 (±11.35 ms) -2.6ms (1.1%) 👌
tablecmp-clear-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-component/clear/1k duration 7.20 (±1.00 ms) 6.55 (±1.20 ms) -0.7ms (9.0%) 👌
tablecmp-create-10k metric base(c2b68ed) target(251357f) trend
benchmark-table-component/create/10k duration 1760.80 (±15.70 ms) 1730.20 (±11.95 ms) -30.6ms (1.7%) 👍
tablecmp-create-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-component/create/1k duration 213.90 (±5.80 ms) 214.05 (±7.00 ms) +0.2ms (0.1%) 👌
tablecmp-update-10th-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-component/update-10th/1k duration 66.65 (±4.95 ms) 66.00 (±4.60 ms) -0.7ms (1.0%) 👌
wc-append-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-wc/append/1k duration 231.15 (±16.45 ms) 236.25 (±14.70 ms) +5.1ms (2.2%) 👌
wc-clear-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-wc/clear/1k duration 12.65 (±1.80 ms) 11.55 (±2.15 ms) -1.1ms (8.7%) 👌
wc-create-10k metric base(c2b68ed) target(251357f) trend
benchmark-table-wc/create/10k duration 1873.20 (±21.60 ms) 1897.10 (±19.80 ms) +23.9ms (1.3%) 👎
wc-create-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-wc/create/1k duration 219.45 (±4.45 ms) 213.80 (±5.30 ms) -5.6ms (2.6%) 👍
wc-update-10th-1k metric base(c2b68ed) target(251357f) trend
benchmark-table-wc/update-10th/1k duration 66.05 (±4.05 ms) 65.55 (±4.05 ms) -0.5ms (0.8%) 👌

@jodarove jodarove removed the work-in-progress Work in progress label May 4, 2019
@jodarove jodarove merged commit 68359c8 into master May 4, 2019
@jodarove jodarove deleted the jodarove/migrate-ie11-flapers branch May 4, 2019 00:53
@jodarove jodarove restored the jodarove/migrate-ie11-flapers branch May 7, 2019 23:22
@jodarove jodarove deleted the jodarove/migrate-ie11-flapers branch May 7, 2019 23:23
ekashida pushed a commit that referenced this pull request May 10, 2019
* test(integration-karma): migrate nested-template-event-target

* test(integration-karma): migrate root-listener-event-target

* test(integration-karma): migrate slotted-custome-element-event-target

* test(integration-karma): migrate nested-render-conditional

* test: increase timeout for two tests that flap in ie11
ekashida added a commit that referenced this pull request May 10, 2019
* fix(engine): fixes #1199 and #1198 - disconnecting bug (#1202) (#1209)

* fix(engine): issues #1199 and #1198 when disconnecting

* fix(engine): PR 1202 feedback

* fix(engine): undefined elm needs protection

* fix(engine): adding tests for PR 1202

* fix(engine): test fix for native shadow

* fix: refactor mutation observer polyfill to fix memory leaks (#1200)

* fix: refactor mutation observer polyfill to fix memory leaks

* fix: address pr feedback

* test(integration-karma): migrate nested-template-event-target (#1207)

* test(integration-karma): migrate nested-template-event-target

* test(integration-karma): migrate root-listener-event-target

* test(integration-karma): migrate slotted-custome-element-event-target

* test(integration-karma): migrate nested-render-conditional

* test: increase timeout for two tests that flap in ie11

* fix(synthetic-shadow): types and bugs in preparation for final split (#1192)

* fix(synthetic-shadow): types and bugs

* fix(synthetic-shadow): activeElement only works if patch on doc

* fix(synthetic-shadow): PR 1192 feedback

* fix(synthetic-shadow): bug fix for async retargeting

* fix: prevent tabbing into subtrees with tabindex -1 (#1206)

* test: adjust tests to reproduce issue

* refactor: tabIndex setter comment

* refactor: keyboard focus handling relative to current context

* test: failing test for internal negative tabindex

* fix: correct tabbing when negative tabindex in zero tabindex

* chore: remove .only

* chore: use getOwnerDocument instead of ownerDocumentGetter

* chore: refactor test to use blocking selenium api

* test(integration-karma): migrate misc tests from integration-test (#1212)

* test(integration-karma): migrate non-composed-events-on-custom-element

* test(integration-karma): migrate events/slotted-native-element

* test(integration-karma): migrate events/window-event-listiner

* test(integration-karma): roolback migrate window-event-listener

* test(integration-karma): migrate rendering/duplicate-text-rendering

* test(integration-karma): migrate rendering/form-tag

* test(integration-karma): migrate rendering/nested-state

* test(integration-karma): migrate rendering/null-logging

* feat(babel): add filename/location to error (#1208)

* feat(babel): add filename/location to error

* wip: fix tests

* wip: return consistent location object

* wip: review comments

* fix: provide a way to disable document patching (#1221)

* fix: provide a way to disable document patching

* fix: update names and move function out
ekashida pushed a commit that referenced this pull request May 14, 2019
* test(integration-karma): migrate nested-template-event-target

* test(integration-karma): migrate root-listener-event-target

* test(integration-karma): migrate slotted-custome-element-event-target

* test(integration-karma): migrate nested-render-conditional

* test: increase timeout for two tests that flap in ie11
ekashida pushed a commit that referenced this pull request May 14, 2019
* test(integration-karma): migrate nested-template-event-target

* test(integration-karma): migrate root-listener-event-target

* test(integration-karma): migrate slotted-custome-element-event-target

* test(integration-karma): migrate nested-render-conditional

* test: increase timeout for two tests that flap in ie11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants