-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(integration-karma): migrate nested-template-event-target #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodarove
force-pushed
the
jodarove/migrate-ie11-flapers
branch
from
May 3, 2019 20:45
a446a63
to
f391d45
Compare
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
approved these changes
May 3, 2019
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
ekashida
pushed a commit
that referenced
this pull request
May 10, 2019
* test(integration-karma): migrate nested-template-event-target * test(integration-karma): migrate root-listener-event-target * test(integration-karma): migrate slotted-custome-element-event-target * test(integration-karma): migrate nested-render-conditional * test: increase timeout for two tests that flap in ie11
ekashida
added a commit
that referenced
this pull request
May 10, 2019
* fix(engine): fixes #1199 and #1198 - disconnecting bug (#1202) (#1209) * fix(engine): issues #1199 and #1198 when disconnecting * fix(engine): PR 1202 feedback * fix(engine): undefined elm needs protection * fix(engine): adding tests for PR 1202 * fix(engine): test fix for native shadow * fix: refactor mutation observer polyfill to fix memory leaks (#1200) * fix: refactor mutation observer polyfill to fix memory leaks * fix: address pr feedback * test(integration-karma): migrate nested-template-event-target (#1207) * test(integration-karma): migrate nested-template-event-target * test(integration-karma): migrate root-listener-event-target * test(integration-karma): migrate slotted-custome-element-event-target * test(integration-karma): migrate nested-render-conditional * test: increase timeout for two tests that flap in ie11 * fix(synthetic-shadow): types and bugs in preparation for final split (#1192) * fix(synthetic-shadow): types and bugs * fix(synthetic-shadow): activeElement only works if patch on doc * fix(synthetic-shadow): PR 1192 feedback * fix(synthetic-shadow): bug fix for async retargeting * fix: prevent tabbing into subtrees with tabindex -1 (#1206) * test: adjust tests to reproduce issue * refactor: tabIndex setter comment * refactor: keyboard focus handling relative to current context * test: failing test for internal negative tabindex * fix: correct tabbing when negative tabindex in zero tabindex * chore: remove .only * chore: use getOwnerDocument instead of ownerDocumentGetter * chore: refactor test to use blocking selenium api * test(integration-karma): migrate misc tests from integration-test (#1212) * test(integration-karma): migrate non-composed-events-on-custom-element * test(integration-karma): migrate events/slotted-native-element * test(integration-karma): migrate events/window-event-listiner * test(integration-karma): roolback migrate window-event-listener * test(integration-karma): migrate rendering/duplicate-text-rendering * test(integration-karma): migrate rendering/form-tag * test(integration-karma): migrate rendering/nested-state * test(integration-karma): migrate rendering/null-logging * feat(babel): add filename/location to error (#1208) * feat(babel): add filename/location to error * wip: fix tests * wip: return consistent location object * wip: review comments * fix: provide a way to disable document patching (#1221) * fix: provide a way to disable document patching * fix: update names and move function out
ekashida
pushed a commit
that referenced
this pull request
May 14, 2019
* test(integration-karma): migrate nested-template-event-target * test(integration-karma): migrate root-listener-event-target * test(integration-karma): migrate slotted-custome-element-event-target * test(integration-karma): migrate nested-render-conditional * test: increase timeout for two tests that flap in ie11
ekashida
pushed a commit
that referenced
this pull request
May 14, 2019
* test(integration-karma): migrate nested-template-event-target * test(integration-karma): migrate root-listener-event-target * test(integration-karma): migrate slotted-custome-element-event-target * test(integration-karma): migrate nested-render-conditional * test: increase timeout for two tests that flap in ie11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Migrates integration tests to karma:
test nested template event target
root-listener-event-target
slotted-custome-element-event-target
nested-render-conditional
Does this PR introduce a breaking change?