Rollup of 5 pull requests #115518

matthiaskrgr · 2023-09-03T19:38:44Z

Successful merges:

RangeFull: Remove parens around .. in documentation snippet #115279 (RangeFull: Remove parens around .. in documentation snippet)
Reference uplifted clippy lints' rustc name in the release notes #115318 (Reference uplifted clippy lints' rustc name in the release notes)
remove some unused crate deps #115445 (remove some unused crate deps)
Use std::io::Error::is_interrupted everywhere #115489 (Use std::io::Error::is_interrupted everywhere)
Command::spawn: Fix STARTUPINFOW.cb being initialized with the address of size_of #115512 (Command::spawn: Fix STARTUPINFOW.cb being initialized with the address of size_of)

r? @ghost
@rustbot modify labels: rollup

I updated to Rust 1.72.0, got a new warning from rustc, wanted to read more about it, so I went to RELEASES.md and searched for the new lint's name as shown in the warning I got. I found no results because the relevant entry in RELEASES only contained the lint's old Clippy name, not its new rustc name. This adds the rustc name for lints so that someone doing the same thing I did will have more success. Some of the uplifted lints didn't have a name change, so I didn't add the rustc name as a search for it will succeed.

…s of size_of

…emote-parens, r=Mark-Simulacrum RangeFull: Remove parens around .. in documentation snippet I’ve removed unnecessary parentheses in a documentation snippet documenting `RangeFull`. It could’ve lead people to believe the parentheses were necessary.

…, r=Mark-Simulacrum Reference uplifted clippy lints' rustc name in the release notes I updated to Rust 1.72.0, got a new warning from rustc, wanted to read more about it, so I went to RELEASES.md and searched for the new lint's name as shown in the warning I got. I found no results because the relevant entry in RELEASES only contained the lint's old Clippy name, not its new rustc name. This adds the rustc name for lints so that someone doing the same thing I did will have more success. Some of the uplifted lints didn't have a name change, so I didn't add the rustc name as a search for it will succeed.

remove some unused crate deps

Use std::io::Error::is_interrupted everywhere In rust-lang#115228 I introduced this helper and started using it, this PR uses it to replace all applicable uses of `std::io::Error::kind`. The justification is the same; for whatever reason LLVM totally flops optimizing `Error::kind` so it's nice to use it less. FYI ``@mkroening`` I swear the hermit changes look good, but I was so sure about the previous PR.

Command::spawn: Fix STARTUPINFOW.cb being initialized with the address of size_of Fixes rust-lang#115511.

matthiaskrgr · 2023-09-03T19:39:43Z

@bors r+ rollup=never p=5

bors · 2023-09-03T19:39:45Z

📌 Commit 487fe2e has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-09-03T21:15:15Z

⌛ Testing commit 487fe2e with merge 58e967a...

bors · 2023-09-03T23:02:47Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 58e967a to master...

rust-timer · 2023-09-03T23:04:14Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#115279	RangeFull: Remove parens around .. in documentation snippet	`c092180e888c99385dbb42cb3ff1afe1f9b75d63` (link)
#115318	Reference uplifted clippy lints' rustc name in the release …	`03d29dc5aa84f6dc61e085962320885256b21105` (link)
#115445	remove some unused crate deps	`9dc640472f19641ce6fe6a5ff91cf17561520279` (link)
#115489	Use std::io::Error::is_interrupted everywhere	`392aa412ff9a185aea0f69b268de41e9252e8577` (link)
#115512	Command::spawn: Fix STARTUPINFOW.cb being initialized with …	`d375c1beec67d995b8907708f9e14b8a0c188ee5` (link)

previous master: 21305f4d5f

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-09-04T05:11:19Z

Finished benchmarking commit (58e967a): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Warning ⚠: The following benchmark(s) failed to build:

cargo-0.60.0

cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	7.1%	[0.7%, 13.6%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.5%, -0.7%]	7
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[-1.5%, 13.6%]	9

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[1.6%, 1.6%]	1
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-3.1%	[-4.9%, -1.5%]	4
Improvements ✅ (secondary)	-5.9%	[-5.9%, -5.9%]	1
All ❌✅ (primary)	-2.2%	[-4.9%, 1.6%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.9%	[0.6%, 9.2%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.1%	[-5.5%, -2.1%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.1%	[-5.5%, 9.2%]	6

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	9
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.2%, -0.0%]	9

Bootstrap: 630.367s -> 628.382s (-0.31%)
Artifact size: 316.68 MiB -> 316.56 MiB (-0.04%)

lqd · 2023-09-04T06:03:32Z

I’m not sure what’s going on here, between the timeout and the big regression, for a rollup with almost no functional changes. Let’s see if it’s this PR, even though it only changes the error path…

@rust-timer build 392aa412ff9a185aea0f69b268de41e9252e8577

lqd · 2023-09-04T07:03:57Z

And bitmaps and cargo opt incr-unchanged kinda look noisy atm, e.g. the latter’s swing back in #115491 (comment)

rust-timer · 2023-09-04T12:45:27Z

Finished benchmarking commit (392aa412ff9a185aea0f69b268de41e9252e8577): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.6%, 0.6%]	1
Improvements ✅ (primary)	-1.0%	[-1.4%, -0.8%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.0%	[-1.4%, -0.8%]	6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-3.2%	[-4.9%, -1.3%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.0%	[-4.9%, 1.5%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.1%	[-5.6%, -2.2%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-4.1%	[-5.6%, -2.2%]	4

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.2%, -0.0%]	9
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.2%, -0.0%]	9

Bootstrap: 630.367s -> 630.435s (0.01%)
Artifact size: 316.68 MiB -> 316.54 MiB (-0.04%)

lqd · 2023-09-04T13:02:53Z

As expected: not it. So between the timeout and swing back up in the next PR, probably noise then?

pnkfelix · 2023-09-06T02:14:00Z

between the timeout and swing back up in the next PR, probably noise then?

agree.

@rustbot label: +perf-regression-triaged

schuelermine and others added 11 commits August 27, 2023 19:16

Remove parens around .. in documentation snippet

2a270a0

remove some unused crate deps

6950689

Add another renamed Clippy lint to release notes

d9af418

Use std::io::Error::is_interrupted everywhere

642251b

Command::spawn: Fix STARTUPINFOW.cb being initialized with the addres…

a8b0e44

…s of size_of

Rollup merge of rust-lang#115445 - klensy:less-deps, r=Mark-Simulacrum

d22043c

remove some unused crate deps

Rollup merge of rust-lang#115512 - Fulgen301:startupinfow, r=ChrisDenton

487fe2e

Command::spawn: Fix STARTUPINFOW.cb being initialized with the address of size_of Fixes rust-lang#115511.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2023

bors merged commit 58e967a into rust-lang:master Sep 3, 2023
11 checks passed

rustbot added this to the 1.74.0 milestone Sep 3, 2023

bors mentioned this pull request Sep 3, 2023

Extract suitable code from rustc_query_impl into a new crate rustc_query_misc #115118

Closed

rustbot added the perf-regression Performance regression. label Sep 4, 2023

This comment has been minimized.

Sign in to view

rustbot added the perf-regression-triaged The performance regression has been triaged. label Sep 6, 2023

matthiaskrgr deleted the rollup-vksprou branch March 16, 2024 18:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #115518

Rollup of 5 pull requests #115518

matthiaskrgr commented Sep 3, 2023

matthiaskrgr commented Sep 3, 2023

bors commented Sep 3, 2023

bors commented Sep 3, 2023

bors commented Sep 3, 2023

rust-timer commented Sep 3, 2023

rust-timer commented Sep 4, 2023

lqd commented Sep 4, 2023 •

edited

Loading

This comment has been minimized.

lqd commented Sep 4, 2023

rust-timer commented Sep 4, 2023

lqd commented Sep 4, 2023

pnkfelix commented Sep 6, 2023

Rollup of 5 pull requests #115518

Rollup of 5 pull requests #115518

Conversation

matthiaskrgr commented Sep 3, 2023

matthiaskrgr commented Sep 3, 2023

bors commented Sep 3, 2023

bors commented Sep 3, 2023

bors commented Sep 3, 2023

rust-timer commented Sep 3, 2023

rust-timer commented Sep 4, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

lqd commented Sep 4, 2023 • edited Loading

This comment has been minimized.

lqd commented Sep 4, 2023

rust-timer commented Sep 4, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

lqd commented Sep 4, 2023

pnkfelix commented Sep 6, 2023

lqd commented Sep 4, 2023 •

edited

Loading