Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command::spawn: Fix STARTUPINFOW.cb being initialized with the address of size_of #115512

Merged
merged 1 commit into from
Sep 3, 2023
Merged

Command::spawn: Fix STARTUPINFOW.cb being initialized with the address of size_of #115512

merged 1 commit into from
Sep 3, 2023

Conversation

Fulgen301
Copy link
Contributor

@Fulgen301 Fulgen301 commented Sep 3, 2023 •
edited
Loading

Fixes #115511.

@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 3, 2023
@ChrisDenton
Copy link
Member

Thank you for the quick fix! I think it safe to assume the PR checks will succeed here so...

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 3, 2023

📌 Commit a8b0e44 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 3, 2023
@Dylan-DPC
Rollup merge of rust-lang#115512 - Fulgen301:startupinfow, r=ChrisDenton
71bc282 
Command::spawn: Fix STARTUPINFOW.cb being initialized with the address of size_of

Fixes rust-lang#115511.
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 3, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 3, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2023
@bors
Auto merge of rust-lang#115518 - matthiaskrgr:rollup-vksprou, r=matth…
58e967a 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#115279 (RangeFull: Remove parens around .. in documentation snippet)
 - rust-lang#115318 (Reference uplifted clippy lints' rustc name in the release notes)
 - rust-lang#115445 (remove some unused crate deps)
 - rust-lang#115489 (Use std::io::Error::is_interrupted everywhere)
 - rust-lang#115512 (Command::spawn: Fix STARTUPINFOW.cb being initialized with the address of size_of)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 487fe2e into rust-lang:master Sep 3, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.74.0
5 participants
@Fulgen301 @rustbot @ChrisDenton @bors @thomcc