Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference uplifted clippy lints' rustc name in the release notes #115318

Merged
merged 2 commits into from
Sep 3, 2023

Conversation

carols10cents
Copy link
Member

I updated to Rust 1.72.0, got a new warning from rustc, wanted to read more about it, so I went to RELEASES.md and searched for the new lint's name as shown in the warning I got.

I found no results because the relevant entry in RELEASES only contained the lint's old Clippy name, not its new rustc name.

This adds the rustc name for lints so that someone doing the same thing I did will have more success.

Some of the uplifted lints didn't have a name change, so I didn't add the rustc name as a search for it will succeed.

I updated to Rust 1.72.0, got a new warning from rustc, wanted to read
more about it, so I went to RELEASES.md and searched for the new lint's
name as shown in the warning I got.

I found no results because the relevant entry in RELEASES only contained
the lint's old Clippy name, not its new rustc name.

This adds the rustc name for lints so that someone doing the same thing
I did will have more success.

Some of the uplifted lints didn't have a name change, so I didn't add
the rustc name as a search for it will succeed.
@rustbot
Copy link
Collaborator

rustbot commented Aug 28, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Aug 28, 2023
@kadiwa4
Copy link
Contributor

kadiwa4 commented Aug 29, 2023

clippy::cast_ref_to_mut was renamed to invalid_reference_casting.

@carols10cents
Copy link
Member Author

@kadiwa4 Thanks! I've added that one as well!

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 3, 2023

📌 Commit d9af418 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 3, 2023
…, r=Mark-Simulacrum

Reference uplifted clippy lints' rustc name in the release notes

I updated to Rust 1.72.0, got a new warning from rustc, wanted to read more about it, so I went to RELEASES.md and searched for the new lint's name as shown in the warning I got.

I found no results because the relevant entry in RELEASES only contained the lint's old Clippy name, not its new rustc name.

This adds the rustc name for lints so that someone doing the same thing I did will have more success.

Some of the uplifted lints didn't have a name change, so I didn't add the rustc name as a search for it will succeed.
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 3, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#115279 (RangeFull: Remove parens around .. in documentation snippet)
 - rust-lang#115318 (Reference uplifted clippy lints' rustc name in the release notes)
 - rust-lang#115445 (remove some unused crate deps)
 - rust-lang#115489 (Use std::io::Error::is_interrupted everywhere)
 - rust-lang#115512 (Command::spawn: Fix STARTUPINFOW.cb being initialized with the address of size_of)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 545560a into rust-lang:master Sep 3, 2023
11 checks passed
@rustbot rustbot added this to the 1.74.0 milestone Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants