Use std::io::Error::is_interrupted everywhere #115489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @m-ou-se (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
O-hermit
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
is-interrupted
branch
from
882a5af to
b6a77ea
Compare
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
is-interrupted
branch
from
b6a77ea to
af1a39f
Compare
mkroening
approved these changes
Sep 3, 2023
saethlin
changed the title
saethlin
force-pushed
the
is-interrupted
branch
from
af1a39f to
642251b
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 3, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#115279 (RangeFull: Remove parens around .. in documentation snippet) - rust-lang#115318 (Reference uplifted clippy lints' rustc name in the release notes) - rust-lang#115445 (remove some unused crate deps) - rust-lang#115489 (Use std::io::Error::is_interrupted everywhere) - rust-lang#115512 (Command::spawn: Fix STARTUPINFOW.cb being initialized with the address of size_of) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #115228 I introduced this helper and started using it, this PR uses it to replace all applicable uses of
std::io::Error::kind. The justification is the same; for whatever reason LLVM totally flops optimizingError::kindso it's nice to use it less.FYI @mkroening I swear the hermit changes look good, but I was so sure about the previous PR.