Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirecting 404 is unfriendly #141

Closed
andersk opened this issue Mar 20, 2015 · 5 comments
Closed

Redirecting 404 is unfriendly #141

andersk opened this issue Mar 20, 2015 · 5 comments
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior E-help-wanted

Comments

@andersk
Copy link

andersk commented Mar 20, 2015

https://crates.io/crates/nonexistent redirects to https://crates.io, which makes it hard to correct a manually typed URL and try again. It also breaks the back button.

BlakeWilliams added a commit to BlakeWilliams/crates.io that referenced this issue Jul 13, 2015
When visiting a crate that doesn't exist the application uses
`transitionTo` to change the route to the index route. This allows the
user to navigate back to the same missing crate route which breaks the
browsers back button.

* Replace `transitionTo` with `replaceWith` to avoid adding history
  entry.

rust-lang#141
@eternaleye
Copy link

Sourceforge has spent the last week demonstrating just how awful this is - it redirecting downloads while the site is broken rather than properly 404'ing has caused real issues for Exherbo's distfile mirroring setup.

@steveklabnik
Copy link
Member

👍

On Thu, Jul 23, 2015 at 8:49 PM, eternaleye [email protected]
wrote:

Sourceforge has spent the last week demonstrating just how awful this is -
it redirecting downloads while the site is broken rather than properly
404'ing has caused real issues for Exherbo's distfile mirroring setup.


Reply to this email directly or view it on GitHub
#141 (comment)
.

@comex
Copy link

comex commented Apr 6, 2016

Bump.

@steveklabnik
Copy link
Member

This no longer redirects!

bors added a commit that referenced this issue Dec 18, 2019
….6.0, r=locks

Bump ember-percy from 1.4.0 to 1.6.0

Bumps [ember-percy](https://github.com/percy/ember-percy) from 1.4.0 to 1.6.0.
<details>
<summary>Release notes</summary>

*Sourced from [ember-percy's releases](https://github.com/percy/ember-percy/releases).*

> ## v1.6.0
> ## What changed?
>
> This version of ember-percy includes more from input serialization when taking the DOM snapshot. You should now see all form inputs properly capture their state ([#146](https://github-redirect.dependabot.com/percy/ember-percy/issues/146))
>
> ## v1.5.0
> Bower was removed - [#73](https://github-redirect.dependabot.com/percy/ember-percy/issues/73)     🎉 🌮 🎉 🗡
> Node 4 was removed from testing - [#75](https://github-redirect.dependabot.com/percy/ember-percy/issues/75) & [#74](https://github-redirect.dependabot.com/percy/ember-percy/issues/74)
> PERCY_PROJECT environment variable is no longer required - [#72](https://github-redirect.dependabot.com/percy/ember-percy/issues/72)  🚀
> Some defensive programming was added - [#71](https://github-redirect.dependabot.com/percy/ember-percy/issues/71) (thanks [@&#8203;Gaurav0](https://github.com/Gaurav0)!) 🛡
>
> ## v1.4.4
> **Important bugfix, please upgrade:**
> - Fix duplicate asset clobbering resource paths. ([#70](https://github-redirect.dependabot.com/percy/ember-percy/issues/70))
>
> ## v1.4.3
> Do not release yarn.lock to npm. Thanks [@&#8203;Turbo87](https://github.com/Turbo87)!
>
> ## v1.4.2
> Fix jQuery version conflict bug. ([#65](https://github-redirect.dependabot.com/percy/ember-percy/issues/65))
>
> ## v1.4.1
> 🐛 Reintroduce support for older ember apps that don't know about `@ember/test` yet.
</details>
<details>
<summary>Commits</summary>

- [`dd7288c`](percy/percy-ember@dd7288c) v1.6.0
- [`a31d5b4`](percy/percy-ember@a31d5b4) feat: Add more form element serialization  ([#146](https://github-redirect.dependabot.com/percy/ember-percy/issues/146))
- [`e387464`](percy/percy-ember@e387464) build(deps): Bump handlebars from 4.0.11 to 4.2.0 ([#145](https://github-redirect.dependabot.com/percy/ember-percy/issues/145))
- [`868783a`](percy/percy-ember@868783a) build(deps): Bump underscore.string from 3.3.4 to 3.3.5 ([#144](https://github-redirect.dependabot.com/percy/ember-percy/issues/144))
- [`8442380`](percy/percy-ember@8442380) build(deps-dev): Bump ember-cli-htmlbars-inline-precompile ([#140](https://github-redirect.dependabot.com/percy/ember-percy/issues/140))
- [`9f503a7`](percy/percy-ember@9f503a7) build(deps-dev): Bump eslint-plugin-node from 9.1.0 to 9.2.0 ([#143](https://github-redirect.dependabot.com/percy/ember-percy/issues/143))
- [`d0786ac`](percy/percy-ember@d0786ac) build(deps): Bump percy-client from 3.0.12 to 3.0.13 ([#142](https://github-redirect.dependabot.com/percy/ember-percy/issues/142))
- [`29877a5`](percy/percy-ember@29877a5) build(deps): Bump ember-cli-babel from 7.10.0 to 7.11.0 ([#141](https://github-redirect.dependabot.com/percy/ember-percy/issues/141))
- [`0109d54`](percy/percy-ember@0109d54) build(deps-dev): Bump ember-load-initializers from 2.0.0 to 2.1.0 ([#139](https://github-redirect.dependabot.com/percy/ember-percy/issues/139))
- [`e8c6f35`](percy/percy-ember@e8c6f35) build(deps): [Security] Bump mixin-deep from 1.3.1 to 1.3.2 ([#138](https://github-redirect.dependabot.com/percy/ember-percy/issues/138))
- Additional commits viewable in [compare view](percy/percy-ember@v1.4.0...v1.6.0)
</details>
<details>
<summary>Maintainer changes</summary>

This version was pushed to npm by [percy-admin](https://www.npmjs.com/~percy-admin), a new releaser for ember-percy since your current version.
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-percy&package-manager=npm_and_yarn&previous-version=1.4.0&new-version=1.6.0)](https://dependabot.com/compatibility-score.html?dependency-name=ember-percy&package-manager=npm_and_yarn&previous-version=1.4.0&new-version=1.6.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
@durka
Copy link
Contributor

durka commented Apr 22, 2021

This has come back!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior E-help-wanted
Projects
None yet
Development

No branches or pull requests

5 participants