Use replaceWith to transition from missing crate
#167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When visiting a crate that doesn't exist the application uses `transitionTo` to change the route to the index route. This allows the user to navigate back to the same missing crate route which breaks the browsers back button. * Replace `transitionTo` with `replaceWith` to avoid adding history entry. rust-lang#141
|
It might also be worth investigating an actual "missing crate" route so typos can easily be fixed instead of having to be written from scratch like the issue says. |
|
Thanks! |
alexcrichton
added a commit
that referenced
this pull request
Jul 13, 2015
Use `replaceWith` to transition from missing crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When visiting a crate that doesn't exist the application uses
transitionToto change the route to the index route. This allows theuser to navigate back to the same missing crate route which breaks the
browsers back button.
transitionTowithreplaceWithto avoid adding historyentry.
#141