Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider README being included in the full text search index #72

Closed
ghost opened this issue Nov 23, 2014 · 4 comments
Closed

Reconsider README being included in the full text search index #72

ghost opened this issue Nov 23, 2014 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 23, 2014

Searching for most common words in https://crates.io will usually return a lot of results, e.g. https://crates.io/search?q=foo. That's because of README.md being full text indexed.

I think it's useful to have README.md indexed but perhaps it could use some preprocessing such as dropping code blocks to reduce the amount of noise.
@alexcrichton
Copy link
Member

Postgres has support for ranking different parts of a document differently for searching, and the README is definitely the lowest factor on the spectrum. I figure it's better to give at least some tangentially relevant search results at least, but this would be very bad if README-hits were higher up than a crate called foo, for example.

Do you have some sample searches which go awry? Or were you just trying to reduce the amount of results?

@killercup killercup mentioned this issue Nov 24, 2014
Closed
@ghost
Copy link
Author

ghost commented Nov 26, 2014

Yeah, this issue borders on a bike shed but I thought it was strange to see so many results for foo that were there only due to a variable being named foo in a code block in their corresponding README.md. But I can imagine situations where that's actually useful so this may as well not be a bug at all.

@alexcrichton
Copy link
Member

Would you be ok closing this in favor of #81? If we showed it on the page it may be more obvious why it's being indexed.

@ghost
Copy link
Author

ghost commented Nov 30, 2014

Certainly, cheers!

@ghost ghost closed this as completed Nov 30, 2014
bors added a commit that referenced this issue Dec 18, 2019
@bors
Auto merge of #1974 - rust-lang:dependabot/npm_and_yarn/ember-percy-1…
4636a2e 
….6.0, r=locks

Bump ember-percy from 1.4.0 to 1.6.0

Bumps [ember-percy](https://github.com/percy/ember-percy) from 1.4.0 to 1.6.0.
<details>
<summary>Release notes</summary>

*Sourced from [ember-percy's releases](https://github.com/percy/ember-percy/releases).*

> ## v1.6.0
> ## What changed?
>
> This version of ember-percy includes more from input serialization when taking the DOM snapshot. You should now see all form inputs properly capture their state ([#146](https://github-redirect.dependabot.com/percy/ember-percy/issues/146))
>
> ## v1.5.0
> Bower was removed - [#73](https://github-redirect.dependabot.com/percy/ember-percy/issues/73)     🎉 🌮 🎉 🗡
> Node 4 was removed from testing - [#75](https://github-redirect.dependabot.com/percy/ember-percy/issues/75) & [#74](https://github-redirect.dependabot.com/percy/ember-percy/issues/74)
> PERCY_PROJECT environment variable is no longer required - [#72](https://github-redirect.dependabot.com/percy/ember-percy/issues/72)  🚀
> Some defensive programming was added - [#71](https://github-redirect.dependabot.com/percy/ember-percy/issues/71) (thanks [@&#8203;Gaurav0](https://github.com/Gaurav0)!) 🛡
>
> ## v1.4.4
> **Important bugfix, please upgrade:**
> - Fix duplicate asset clobbering resource paths. ([#70](https://github-redirect.dependabot.com/percy/ember-percy/issues/70))
>
> ## v1.4.3
> Do not release yarn.lock to npm. Thanks [@&#8203;Turbo87](https://github.com/Turbo87)!
>
> ## v1.4.2
> Fix jQuery version conflict bug. ([#65](https://github-redirect.dependabot.com/percy/ember-percy/issues/65))
>
> ## v1.4.1
> 🐛 Reintroduce support for older ember apps that don't know about `@ember/test` yet.
</details>
<details>
<summary>Commits</summary>

- [`dd7288c`](percy/percy-ember@dd7288c) v1.6.0
- [`a31d5b4`](percy/percy-ember@a31d5b4) feat: Add more form element serialization  ([#146](https://github-redirect.dependabot.com/percy/ember-percy/issues/146))
- [`e387464`](percy/percy-ember@e387464) build(deps): Bump handlebars from 4.0.11 to 4.2.0 ([#145](https://github-redirect.dependabot.com/percy/ember-percy/issues/145))
- [`868783a`](percy/percy-ember@868783a) build(deps): Bump underscore.string from 3.3.4 to 3.3.5 ([#144](https://github-redirect.dependabot.com/percy/ember-percy/issues/144))
- [`8442380`](percy/percy-ember@8442380) build(deps-dev): Bump ember-cli-htmlbars-inline-precompile ([#140](https://github-redirect.dependabot.com/percy/ember-percy/issues/140))
- [`9f503a7`](percy/percy-ember@9f503a7) build(deps-dev): Bump eslint-plugin-node from 9.1.0 to 9.2.0 ([#143](https://github-redirect.dependabot.com/percy/ember-percy/issues/143))
- [`d0786ac`](percy/percy-ember@d0786ac) build(deps): Bump percy-client from 3.0.12 to 3.0.13 ([#142](https://github-redirect.dependabot.com/percy/ember-percy/issues/142))
- [`29877a5`](percy/percy-ember@29877a5) build(deps): Bump ember-cli-babel from 7.10.0 to 7.11.0 ([#141](https://github-redirect.dependabot.com/percy/ember-percy/issues/141))
- [`0109d54`](percy/percy-ember@0109d54) build(deps-dev): Bump ember-load-initializers from 2.0.0 to 2.1.0 ([#139](https://github-redirect.dependabot.com/percy/ember-percy/issues/139))
- [`e8c6f35`](percy/percy-ember@e8c6f35) build(deps): [Security] Bump mixin-deep from 1.3.1 to 1.3.2 ([#138](https://github-redirect.dependabot.com/percy/ember-percy/issues/138))
- Additional commits viewable in [compare view](percy/percy-ember@v1.4.0...v1.6.0)
</details>
<details>
<summary>Maintainer changes</summary>

This version was pushed to npm by [percy-admin](https://www.npmjs.com/~percy-admin), a new releaser for ember-percy since your current version.
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-percy&package-manager=npm_and_yarn&previous-version=1.4.0&new-version=1.6.0)](https://dependabot.com/compatibility-score.html?dependency-name=ember-percy&package-manager=npm_and_yarn&previous-version=1.4.0&new-version=1.6.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
Turbo87 pushed a commit to Turbo87/crates.io that referenced this issue Dec 7, 2022
@renovate
Lock file maintenance (rust-lang#72)
ae6035c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Turbo87 pushed a commit to Turbo87/crates.io that referenced this issue Jan 4, 2023
@renovate @renovate-bot
Update Rust crate tracing-subscriber to 0.3.6 (rust-lang#72)
b149c44 
Co-authored-by: Renovate Bot <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexcrichton