Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow people to directly download crate source tarball #65

Closed
sfackler opened this issue Nov 22, 2014 · 9 comments
Closed

Allow people to directly download crate source tarball #65

sfackler opened this issue Nov 22, 2014 · 9 comments
Labels
C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works

Comments

@sfackler
Copy link
Member

I find it useful if I want to check out a package before depending on it or need to look at the source.
@alexcrichton
Copy link
Member

This was originally offered, but this is somewhat nuanced. The fact that the download is a tarball is an implementation detail, so this would need to be accompanied with equivalent support in Cargo itself it inspect and unpack the .crate file that was downloaded.

@gdamjan
Copy link

gdamjan commented Mar 5, 2016

There needs to be some pointer to the source, regardless what's in the projects Cargo.toml.

Take for ex. https://crates.io/crates/servo-glutin/0.4.10 the only link is to https://github.com/tomaka/glutin which doesn't even have a 0.4.10 version/tag (and this is actually the servo/glutin repo).

The servo/glutin repo only has a servo-0.4.10 tag, which I don't know if is the version on crates.io

@flying-sheep
Copy link

as a packager, i need this. i need to point to a file and say “download this and verify with that sha1” instead of “let something download stuff for me”

@carols10cents carols10cents added the C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works label Dec 15, 2016
@carols10cents
Copy link
Member

So the URLs https://crates.io/api/v1/crates/name/version/download work, but that's not really exposed anywhere.

In what manner would yinz want to see this exposed? API docs? A link on the crate page?

@ljedrz
Copy link

ljedrz commented Jul 25, 2017 •
edited
Loading

So the URLs https://crates.io/api/v1/crates/name/version/download work

It doesn't work anymore; it used to in the past, but I tried it with a few crates and it didn't do the trick, at least not with a browser.

related Stack Overflow question

@carols10cents
Copy link
Member

carols10cents commented Jul 25, 2017 •
edited
Loading

It doesn't work anymore; it used to in the past, but I tried it with a few crates and it didn't do the trick, at least not with a browser.

It won't work with a browser, no, but curl should work.

@ljedrz
Copy link

ljedrz commented Jul 25, 2017

It won't work with a browser, no, but curl should work.

I checked it; it works.

I would suggest describing this download method in the API docs, especially since it is not trivial - you need to pass the -L option (follow redirects), otherwise you may not receive anything. In addition, although the downloaded file's extension is .crate (and after unzipping it the file has a .crate extension again), it is a tarball (.tar.gz).

@sgrif
Copy link
Contributor

sgrif commented Jul 25, 2017

It should work in the browser after the next deploy

@carols10cents
Copy link
Member

Deployed! this should now work!

@nightkr nightkr mentioned this issue Feb 7, 2019
Closed
bors added a commit that referenced this issue Dec 18, 2019
@bors
Auto merge of #1974 - rust-lang:dependabot/npm_and_yarn/ember-percy-1…
4636a2e 
….6.0, r=locks

Bump ember-percy from 1.4.0 to 1.6.0

Bumps [ember-percy](https://github.com/percy/ember-percy) from 1.4.0 to 1.6.0.
<details>
<summary>Release notes</summary>

*Sourced from [ember-percy's releases](https://github.com/percy/ember-percy/releases).*

> ## v1.6.0
> ## What changed?
>
> This version of ember-percy includes more from input serialization when taking the DOM snapshot. You should now see all form inputs properly capture their state ([#146](https://github-redirect.dependabot.com/percy/ember-percy/issues/146))
>
> ## v1.5.0
> Bower was removed - [#73](https://github-redirect.dependabot.com/percy/ember-percy/issues/73)     🎉 🌮 🎉 🗡
> Node 4 was removed from testing - [#75](https://github-redirect.dependabot.com/percy/ember-percy/issues/75) & [#74](https://github-redirect.dependabot.com/percy/ember-percy/issues/74)
> PERCY_PROJECT environment variable is no longer required - [#72](https://github-redirect.dependabot.com/percy/ember-percy/issues/72)  🚀
> Some defensive programming was added - [#71](https://github-redirect.dependabot.com/percy/ember-percy/issues/71) (thanks [@&#8203;Gaurav0](https://github.com/Gaurav0)!) 🛡
>
> ## v1.4.4
> **Important bugfix, please upgrade:**
> - Fix duplicate asset clobbering resource paths. ([#70](https://github-redirect.dependabot.com/percy/ember-percy/issues/70))
>
> ## v1.4.3
> Do not release yarn.lock to npm. Thanks [@&#8203;Turbo87](https://github.com/Turbo87)!
>
> ## v1.4.2
> Fix jQuery version conflict bug. ([#65](https://github-redirect.dependabot.com/percy/ember-percy/issues/65))
>
> ## v1.4.1
> 🐛 Reintroduce support for older ember apps that don't know about `@ember/test` yet.
</details>
<details>
<summary>Commits</summary>

- [`dd7288c`](percy/percy-ember@dd7288c) v1.6.0
- [`a31d5b4`](percy/percy-ember@a31d5b4) feat: Add more form element serialization  ([#146](https://github-redirect.dependabot.com/percy/ember-percy/issues/146))
- [`e387464`](percy/percy-ember@e387464) build(deps): Bump handlebars from 4.0.11 to 4.2.0 ([#145](https://github-redirect.dependabot.com/percy/ember-percy/issues/145))
- [`868783a`](percy/percy-ember@868783a) build(deps): Bump underscore.string from 3.3.4 to 3.3.5 ([#144](https://github-redirect.dependabot.com/percy/ember-percy/issues/144))
- [`8442380`](percy/percy-ember@8442380) build(deps-dev): Bump ember-cli-htmlbars-inline-precompile ([#140](https://github-redirect.dependabot.com/percy/ember-percy/issues/140))
- [`9f503a7`](percy/percy-ember@9f503a7) build(deps-dev): Bump eslint-plugin-node from 9.1.0 to 9.2.0 ([#143](https://github-redirect.dependabot.com/percy/ember-percy/issues/143))
- [`d0786ac`](percy/percy-ember@d0786ac) build(deps): Bump percy-client from 3.0.12 to 3.0.13 ([#142](https://github-redirect.dependabot.com/percy/ember-percy/issues/142))
- [`29877a5`](percy/percy-ember@29877a5) build(deps): Bump ember-cli-babel from 7.10.0 to 7.11.0 ([#141](https://github-redirect.dependabot.com/percy/ember-percy/issues/141))
- [`0109d54`](percy/percy-ember@0109d54) build(deps-dev): Bump ember-load-initializers from 2.0.0 to 2.1.0 ([#139](https://github-redirect.dependabot.com/percy/ember-percy/issues/139))
- [`e8c6f35`](percy/percy-ember@e8c6f35) build(deps): [Security] Bump mixin-deep from 1.3.1 to 1.3.2 ([#138](https://github-redirect.dependabot.com/percy/ember-percy/issues/138))
- Additional commits viewable in [compare view](percy/percy-ember@v1.4.0...v1.6.0)
</details>
<details>
<summary>Maintainer changes</summary>

This version was pushed to npm by [percy-admin](https://www.npmjs.com/~percy-admin), a new releaser for ember-percy since your current version.
</details>
<br />

[![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=ember-percy&package-manager=npm_and_yarn&previous-version=1.4.0&new-version=1.6.0)](https://dependabot.com/compatibility-score.html?dependency-name=ember-percy&package-manager=npm_and_yarn&previous-version=1.4.0&new-version=1.6.0)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Pull request limits (per update run and/or open at any time)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

</details>
@hvenev hvenev mentioned this issue Jul 16, 2020
Closed
@bronson bronson mentioned this issue Apr 27, 2021
Closed
@mkroening mkroening mentioned this issue Dec 17, 2021
Closed
Turbo87 referenced this issue in Turbo87/crates.io Dec 7, 2022
@renovate
Update thiserror crate to 1.0.36 (#65)
8ec7273 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Turbo87 referenced this issue in Turbo87/crates.io Jan 4, 2023
@renovate @renovate-bot
Lock file maintenance (#65)
a75dc31 
Co-authored-by: Renovate Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@alexcrichton @gdamjan @carols10cents @flying-sheep @sfackler @sgrif @ljedrz