Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed slam launch file according to the comments for the PR #4211 #4259

Closed
wants to merge 1 commit into from

Conversation

iOzcan1
Copy link

@iOzcan1 iOzcan1 commented Apr 11, 2024


Basic Info

Info I have followed the comments on PR #4211 to make the changes
Ticket(s) this addresses #4211 #4202
Primary OS tested on Ubuntu 22.04
Robotic platform tested on Gazebo simulation, turtlebot3
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link
Contributor

mergify bot commented Apr 11, 2024

@iOzcan1, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

@SteveMacenski
Copy link
Member

@iOzcan1 please fix the linting + DCO issues. You also need to rebase or pull in main to your PR to make CI turn over

Copy link
Contributor

mergify bot commented Apr 12, 2024

@iOzcan1, your PR has failed to build. Please check CI outputs and resolve issues.
You may need to rebase or pull in main due to API changes (or your contribution genuinely fails).

@SteveMacenski
Copy link
Member

SteveMacenski commented Apr 12, 2024

@SteveMacenski
Copy link
Member

SteveMacenski commented Apr 23, 2024

Will fix and open a PR shortly to get this in. @iOzcan1 thanks for getting this started! Very appreciated, but just going to finish up the details so that your contribution gets into main sooner than later 😄

SteveMacenski added a commit that referenced this pull request Apr 23, 2024
* changed slam launch file according to the comments for the PR #4211

Signed-off-by: Ibrahim Özcan <[email protected]>

* Fixing litning problems

---------

Signed-off-by: Ibrahim Özcan <[email protected]>
Co-authored-by: Ibrahim Özcan <[email protected]>
enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
* changed slam launch file according to the comments for the PR ros-navigation#4211

Signed-off-by: Ibrahim Özcan <[email protected]>

* Fixing litning problems

---------

Signed-off-by: Ibrahim Özcan <[email protected]>
Co-authored-by: Ibrahim Özcan <[email protected]>
Signed-off-by: enricosutera <[email protected]>
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
* changed slam launch file according to the comments for the PR ros-navigation#4211

Signed-off-by: Ibrahim Özcan <[email protected]>

* Fixing litning problems

---------

Signed-off-by: Ibrahim Özcan <[email protected]>
Co-authored-by: Ibrahim Özcan <[email protected]>
savalena pushed a commit to savalena/navigation2 that referenced this pull request Jul 5, 2024
* changed slam launch file according to the comments for the PR ros-navigation#4211

Signed-off-by: Ibrahim Özcan <[email protected]>

* Fixing litning problems

---------

Signed-off-by: Ibrahim Özcan <[email protected]>
Co-authored-by: Ibrahim Özcan <[email protected]>
Manos-G pushed a commit to Manos-G/navigation2 that referenced this pull request Aug 1, 2024
* changed slam launch file according to the comments for the PR ros-navigation#4211

Signed-off-by: Ibrahim Özcan <[email protected]>

* Fixing litning problems

---------

Signed-off-by: Ibrahim Özcan <[email protected]>
Co-authored-by: Ibrahim Özcan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants