-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed slam launch file according to the comments for the PR #4211 #4259
Conversation
@iOzcan1, your PR has failed to build. Please check CI outputs and resolve issues. |
@iOzcan1 please fix the linting + DCO issues. You also need to rebase or pull in |
@iOzcan1, your PR has failed to build. Please check CI outputs and resolve issues. |
…igation#4211 Signed-off-by: Ibrahim Özcan <[email protected]>
Linter is still failing :( You can see the details in Actions or https://app.circleci.com/pipelines/github/ros-planning/navigation2/11451/workflows/7b699eb7-8951-4c0d-986c-190fa7c26176/jobs/35289/tests |
Will fix and open a PR shortly to get this in. @iOzcan1 thanks for getting this started! Very appreciated, but just going to finish up the details so that your contribution gets into main sooner than later 😄 |
* changed slam launch file according to the comments for the PR #4211 Signed-off-by: Ibrahim Özcan <[email protected]> * Fixing litning problems --------- Signed-off-by: Ibrahim Özcan <[email protected]> Co-authored-by: Ibrahim Özcan <[email protected]>
* changed slam launch file according to the comments for the PR ros-navigation#4211 Signed-off-by: Ibrahim Özcan <[email protected]> * Fixing litning problems --------- Signed-off-by: Ibrahim Özcan <[email protected]> Co-authored-by: Ibrahim Özcan <[email protected]> Signed-off-by: enricosutera <[email protected]>
* changed slam launch file according to the comments for the PR ros-navigation#4211 Signed-off-by: Ibrahim Özcan <[email protected]> * Fixing litning problems --------- Signed-off-by: Ibrahim Özcan <[email protected]> Co-authored-by: Ibrahim Özcan <[email protected]>
* changed slam launch file according to the comments for the PR ros-navigation#4211 Signed-off-by: Ibrahim Özcan <[email protected]> * Fixing litning problems --------- Signed-off-by: Ibrahim Özcan <[email protected]> Co-authored-by: Ibrahim Özcan <[email protected]>
* changed slam launch file according to the comments for the PR ros-navigation#4211 Signed-off-by: Ibrahim Özcan <[email protected]> * Fixing litning problems --------- Signed-off-by: Ibrahim Özcan <[email protected]> Co-authored-by: Ibrahim Özcan <[email protected]>
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: