Ahcorde/add/joint limit interface #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ddengster <[email protected]> Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: ahcorde <[email protected]>
…ntStateHandle or JointCommandHandle). Refactred common functionality into base JointSaturationLimitHandle and JointSoftLimitsHandle classes.
This was referenced Oct 4, 2020
|
LICENSING FYI @v-lopez @destogl @bmagyar I changed the file header licenses to Apache 2 as discussed here. |
AndyZe
reviewed
Oct 5, 2020
|
@ahcorde we'd appreciate your feedback on this one |
|
@bmagyar @Karsten1987 @destogl In this refactor for #134 I went with JointHandle arguments wrapped in std::shared_ptr<>, should these have been without shared_ptr? This was due to a commit I was using as a reference that had shared_ptr, but after reviewing more code such as robot_hardware.cpp I dont see any reason to use shared_ptr here, the JontHandle by value would work fine and probably more compatible. Thoughts? |
bmagyar
reviewed
Oct 10, 2020
joint_limits_interface/include/joint_limits_interface/joint_limits_interface.hpp
Show resolved
Hide resolved
bmagyar
reviewed
Oct 10, 2020
bmagyar
reviewed
Oct 10, 2020
bmagyar
reviewed
Oct 10, 2020
bmagyar
reviewed
Oct 10, 2020
bmagyar
reviewed
Oct 10, 2020
bmagyar
reviewed
Oct 10, 2020
bmagyar
reviewed
Oct 10, 2020
bmagyar
reviewed
Oct 10, 2020
bmagyar
approved these changes
Oct 10, 2020
This was referenced Oct 10, 2020
guru-florida
added a commit
to guru-florida/ros2_control
that referenced
this pull request
Oct 23, 2020
* Added joint_limits_interface - Direct port from ROS 1 * Follow ros2 styles and added tests * Added missing dependencies in package.xml * updated joint limits interface exception to nothrow and match base override * converted joint limit interfaces to use new JointHandles (no more JointStateHandle or JointCommandHandle). Refactored common functionality into base JointSaturationLimitHandle and JointSoftLimitsHandle classes. * updated joint limits tests to use new JointHandles * updated package version from 2 to 3 * added memory include as suggested by ros_industrial test * uncrustify fixes * removing changelog from ROS1 * Reset version and fix links * Update maintainers Co-authored-by: ddengster <[email protected]> Co-authored-by: ahcorde <[email protected]> Co-authored-by: Bence Magyar <[email protected]> Co-authored-by: Colin MacKenzie guru-florida
destogl
pushed a commit
to StoglRobotics-forks/ros2_control
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @destogl, this is a follow-on to a PR by ahcorde, PR135.
This PR has joint_limit_interface updated with #134 changes which remote state and command handles and replace with just JointHandle. It has been synced with the latest ros2_control/master branch.
Also all tests (previously commented out) have been fixed up and pass on my local system.
Suggesting review by @Karsten1987 @bmagyar as well.
This PR:
Originally coded by: @ddengster [email protected]
Signed-off-by: @ahcorde [email protected]
#134, refactor + unit tests by myself: guru-florida
I believe ahcorde and I are both working to the same goal of getting gazeobo+ros+ros-control working together! :) Kudos to all, we are so close!
FYI I also have transmission_interface similarly updated with master in PR182. This PR is also included in PR182 so you can just approve and do that one, or both, PR182 is based from 181 and both synced to master so no worries. It's just a matter of scope.