-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old joint state and joint command handles #134
Remove old joint state and joint command handles #134
Conversation
4415235
to
de6f33a
Compare
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 37.25% 36.61% -0.64%
==========================================
Files 44 42 -2
Lines 1863 1726 -137
Branches 1136 1080 -56
==========================================
- Hits 694 632 -62
+ Misses 130 100 -30
+ Partials 1039 994 -45
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
250cf43
to
cd60339
Compare
@jordan-palacios do you need this for ros-controls/ros2_controllers#90? Is this ready for review? @bmagyar @Karsten1987 I would propose to merge this one and then start porting to new |
Yes. As soon as ros-controls/ros2_controllers#90 is merged. You can review it meanwhile if you like. |
cd60339
to
1bacac0
Compare
Remove all trace to
hardware_interface::JointStateHandle
andhardware_interface::JointCommandHandle
.Requires #125 and ros-controls/ros2_controllers#90.
Closes #125.