Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple of typos #2593

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Fix a couple of typos #2593

merged 3 commits into from
Jun 8, 2021

Conversation

drdanz
Copy link
Member

@drdanz drdanz commented Jun 7, 2021

Libraries

sig

IntrinsicParams

  • Deprecate YARP_PLUM_BOB in favour of YARP_PLUMB_BOB

dev

IDepthVisualParams

  • The retificationMatrix parameter was renamed rectificationMatrix

IRgbVisualParams

  • The retificationMatrix parameter was renamed rectificationMatrix

@drdanz drdanz added Component: Library - YARP_dev Component: Library - YARP_sig Type: Cleanup Involves cleaning up some part of YARP Type: Breaking/Behaviour Change Involves breaking user code or behaviour Type: Deprecation Involves deprecating some part of YARP Target: YARP v3.5.0 labels Jun 7, 2021
@drdanz
Copy link
Member Author

drdanz commented Jun 7, 2021

CC @triccyx

@drdanz drdanz temporarily deployed to code-analysis June 7, 2021 14:33 Inactive
@drdanz drdanz temporarily deployed to code-analysis June 7, 2021 14:33 Inactive
@drdanz drdanz temporarily deployed to code-analysis June 7, 2021 14:33 Inactive
This was referenced Jun 7, 2021
Merged
Merged
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

46.9% 46.9% Coverage
0.0% 0.0% Duplication

Nicogene
Nicogene approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@Nicogene Nicogene left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me, we should coordinate with external repositories such as yarp-device-realsense2 for YARP_PLUMB_BOB changes (https://github.com/robotology/yarp-device-realsense2/search?q=YARP_PLUM_BOB).

cc @traversaro

@traversaro
Copy link
Member

YARP_PLUMB_BOB

I guess the deprecation as done now should work fine.

@drdanz
Copy link
Member Author

drdanz commented Jun 8, 2021 •
edited
Loading

The YARP_PLUM_BOB deprecation will print a warning when used, the breaking change is the "retificationMatrix" -> "rectificationMatrix" string, which seems to be used in yarp-device-ultrapython (cc @triccyx), gazebo-yarp-plugins (cc @traversaro) and icub-main (firewire camera) (cc @Nicogene @pattacini).
I don't think that anyone is actually using it, this is just a parameter set by the cameras.

@drdanz

This comment has been minimized.

Sign in to view
@drdanz drdanz added the PR Status: Continuous Integration - OK Continuous Integration for this PR passed (invalid if commits were added or modified after this) label Jun 8, 2021
@drdanz drdanz force-pushed the fix_rectificationMatrix_param branch from bcf5d96 to 9800983 Compare June 8, 2021 18:59
@drdanz drdanz merged commit 18539a7 into robotology:master Jun 8, 2021
@drdanz drdanz deleted the fix_rectificationMatrix_param branch June 8, 2021 19:01
pattacini added a commit to robotology/icub-main that referenced this pull request Jun 8, 2021
@pattacini
fixed typo
8797777 
see robotology/yarp#2593 (comment)
@traversaro traversaro mentioned this pull request Jun 28, 2021
Merged
drdanz added a commit to drdanz/gazebo-yarp-plugins that referenced this pull request Jun 28, 2021
@drdanz
Update retificationMatrix -> rectificationMatrix
09c2502 
See also robotology/yarp#2593
drdanz added a commit to drdanz/gazebo-yarp-plugins that referenced this pull request Jun 28, 2021
@drdanz
Update retificationMatrix -> rectificationMatrix
485f272 
See also robotology/yarp#2593
drdanz added a commit to drdanz/gazebo-yarp-plugins that referenced this pull request Jun 28, 2021
@drdanz
Update retificationMatrix -> rectificationMatrix
424f36a 
See also robotology/yarp#2593
drdanz added a commit to drdanz/gazebo-yarp-plugins that referenced this pull request Jun 28, 2021
@drdanz
Update retificationMatrix -> rectificationMatrix
0559954 
See also robotology/yarp#2593
@traversaro traversaro mentioned this pull request Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicogene Nicogene Nicogene approved these changes

@traversaro traversaro traversaro approved these changes

@randaz81 randaz81 Awaiting requested review from randaz81 randaz81 is a code owner

Assignees

@drdanz drdanz

@ste93 ste93

Labels
Component: Library - YARP_dev Component: Library - YARP_sig PR Status: Continuous Integration - OK Continuous Integration for this PR passed (invalid if commits were added or modified after this) Resolution: Merged Target: YARP v3.5.0 Type: Breaking/Behaviour Change Involves breaking user code or behaviour Type: Cleanup Involves cleaning up some part of YARP Type: Deprecation Involves deprecating some part of YARP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drdanz @traversaro @Nicogene @ste93