yarp::dev::IRgbVisualParams in multicamera and depthCamera

[drdanz]

Unfortunately, at the moment, in YARP we don't have an interface for a multicamera. This means that, if the camera parameters are different, this will work properly only for the first camera.

Depends on #560

[traversaro]

Just to clarify, the source of this code is the existing code in gazebo_yarp_depthcamera, right? Not sure if you want to fix the retificationMatrix typo after robotology/yarp#2593 ?

[traversaro]

Can you update the CHANGELOG?

[traversaro]

To fix the CI, you may want to rebase over latest devel to get #557 .

[drdanz]

Just to clarify, the source of this code is the existing code in gazebo_yarp_depthcamera, right? Not sure if you want to fix the retificationMatrix typo after robotology/yarp#2593 ?

Yes, I was saving it for the next PR, where I was fixing this, and the depthcamera, and also fixing getRgbIntrinsicParam when the distortion is not set, but perhaps it is better to have it all in one PR, I'll update it...

[traversaro]

Just to clarify, the source of this code is the existing code in gazebo_yarp_depthcamera, right? Not sure if you want to fix the retificationMatrix typo after robotology/yarp#2593 ?

Yes, I was saving it for the next PR, where I was fixing this, and the depthcamera, and also fixing getRgbIntrinsicParam when the distortion is not set, but perhaps it is better to have it all in one PR, I'll update it...

Ok, let's leave it for the next PR then!

[drdanz]

Ok, let's leave it for the next PR then!

Too late, just updated the PR 😆

[drdanz]

Should this be master for gazebo-yarp-plugin devel branch?

gazebo-yarp-plugins/.github/workflows/ci.yml

Line 31 in 90df156

yarp_version: yarp-3.4

[drdanz]

Rebased over #560 in order to build with YARP master

[drdanz]

@traversaro: All checks have passed. Can we merge this, so that I can rebase #559?

[drdanz]

Thanks @traversaro